fix(tests): drop removed TrueAffectedConfig fields from integration test literals - #92
Merged
Merged
Conversation
…est literals #83 removed root_ts_config/include/ignored_paths from TrueAffectedConfig, but #84/#86/#89/#90 had each added new test literals still setting them. Those merged without textual conflict, so main's integration test binary stopped compiling (E0560 x6) while every PR reported mergeable. Removes the six stale field initializers. All suites green: lib 239, integration 74, cli 16.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughIntegration test configurations are updated to match the revised ChangesTrueAffectedConfig test updates
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
📦 Preview Release AvailableA preview release has been published for commit 5894d2d. Installationnpm install https://github.com/frontops-dev/domino/releases/download/pr-92-5894d2d/front-ops-domino-1.5.0.tgzRunning the previewnpx https://github.com/frontops-dev/domino/releases/download/pr-92-5894d2d/front-ops-domino-1.5.0.tgz affectedDetails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainis red — the integration test binary does not compile (6×E0560: struct \TrueAffectedConfig` has no field named ...attests/integration_test.rs`:2514/2541/2542/4526/4528/4529). Failing runCause: a semantic conflict that no PR could see. #83 removed
root_ts_config/include/ignored_pathsfromTrueAffectedConfigand cleaned up every test literal that existed at the time. Meanwhile #84, #86, #89 and #90 each added new test literals that still set those fields. Each PR was individually green and textually conflict-free, so GitHub reported them all mergeable — but the union doesn't compile.Solution
Delete the six stale field initializers. No production code touched.
Testing
cargo test --no-default-features --test integration_test -- --test-threads=1→ 74 passed, 0 failed (previously: did not compile)cargo test --no-default-features --lib→ 239 passedcargo test --no-default-features --test cli_test -- --test-threads=1→ 16 passedcargo clippy --all-targets --no-default-featuresclean,cargo fmt --checkcleanNote for the remaining PRs
#85, #87 and #88 are still open and will hit the same thing when they merge
main: any test literal they add must not carry the three removed fields. Their branch updates are in progress.Summary by CodeRabbit