Skip to content

fix(tests): drop removed TrueAffectedConfig fields from integration test literals - #92

Merged
shaharkazaz merged 1 commit into
mainfrom
fix/main-test-compile
Jul 27, 2026
Merged

fix(tests): drop removed TrueAffectedConfig fields from integration test literals#92
shaharkazaz merged 1 commit into
mainfrom
fix/main-test-compile

Conversation

@shaharkazaz

@shaharkazaz shaharkazaz commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Problem

main is red — the integration test binary does not compile (6× E0560: struct \TrueAffectedConfig` has no field named ...attests/integration_test.rs`:2514/2541/2542/4526/4528/4529). Failing run

Cause: a semantic conflict that no PR could see. #83 removed root_ts_config/include/ignored_paths from TrueAffectedConfig and cleaned up every test literal that existed at the time. Meanwhile #84, #86, #89 and #90 each added new test literals that still set those fields. Each PR was individually green and textually conflict-free, so GitHub reported them all mergeable — but the union doesn't compile.

Solution

Delete the six stale field initializers. No production code touched.

Testing

  • cargo test --no-default-features --test integration_test -- --test-threads=174 passed, 0 failed (previously: did not compile)
  • cargo test --no-default-features --lib → 239 passed
  • cargo test --no-default-features --test cli_test -- --test-threads=1 → 16 passed
  • cargo clippy --all-targets --no-default-features clean, cargo fmt --check clean

Note for the remaining PRs

#85, #87 and #88 are still open and will hit the same thing when they merge main: any test literal they add must not carry the three removed fields. Their branch updates are in progress.

Summary by CodeRabbit

  • Tests
    • Updated integration test configuration setup to align with the current configuration format.
    • Adjusted asset batching and Turborepo test scenarios without changing end-user functionality.

…est literals

#83 removed root_ts_config/include/ignored_paths from TrueAffectedConfig,
but #84/#86/#89/#90 had each added new test literals still setting them.
Those merged without textual conflict, so main's integration test binary
stopped compiling (E0560 x6) while every PR reported mergeable.

Removes the six stale field initializers. All suites green: lib 239,
integration 74, cli 16.
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a50e436f-8424-4ad0-8dc5-a4503065c728

📥 Commits

Reviewing files that changed from the base of the PR and between 0da0cd0 and 5894d2d.

📒 Files selected for processing (1)
  • tests/integration_test.rs
💤 Files with no reviewable changes (1)
  • tests/integration_test.rs

📝 Walkthrough

Walkthrough

Integration test configurations are updated to match the revised TrueAffectedConfig shape by removing obsolete fields and relying on defaults.

Changes

TrueAffectedConfig test updates

Layer / File(s) Summary
Update integration test configurations
tests/integration_test.rs
Asset batching and Turborepo test configurations remove root_ts_config, include, and ignored_paths while retaining supported fields.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the test-only change removing obsolete TrueAffectedConfig fields.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/main-test-compile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Preview Release Available

A preview release has been published for commit 5894d2d.

Installation

npm install https://github.com/frontops-dev/domino/releases/download/pr-92-5894d2d/front-ops-domino-1.5.0.tgz

Running the preview

npx https://github.com/frontops-dev/domino/releases/download/pr-92-5894d2d/front-ops-domino-1.5.0.tgz affected

Details

@shaharkazaz
shaharkazaz merged commit 578e874 into main Jul 27, 2026
27 of 39 checks passed
@shaharkazaz
shaharkazaz deleted the fix/main-test-compile branch July 27, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant