feat(workspace): merge package-manager workspace members into Nx discovery - #78
feat(workspace): merge package-manager workspace members into Nx discovery#78gbleu wants to merge 1 commit into
Conversation
…overy Nx-mode discovery returned exclusively the projects that have a project.json. Real Nx workspaces infer most projects from package.json scripts via the package manager's workspace globs — on a 250-package monorepo only 25 had a project.json, so edits in the other 225 packages were invisible: a changed file attributed to no project silently yields an empty affected set. When the workspace is also an npm/yarn/pnpm/bun workspace, merge the members that Nx-mode discovery didn't already cover (deduplicated by project root and name; project.json wins). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📦 Preview Release AvailableA preview release has been published for commit b1ca585. Installationnpm install https://github.com/frontops-dev/domino/releases/download/pr-78-b1ca585/front-ops-domino-1.4.0.tgzRunning the previewnpx https://github.com/frontops-dev/domino/releases/download/pr-78-b1ca585/front-ops-domino-1.4.0.tgz affectedDetails |
1 participant
Fixes #70.
Problem
Nx-mode discovery (
discover_projects→nx::get_projects) returns only the projects that have aproject.json. Real Nx workspaces infer most projects frompackage.jsonscripts via the package manager's workspace globs, so the Nx project set is a superset of theproject.jsonfiles. On a 250-package pnpm monorepo only 25 packages had aproject.json— edits in the other 225 were attributed to no project, silently yielding an empty affected set (a false-green for CI gating).Fix
When an Nx workspace is also an npm/yarn/pnpm/bun workspace, merge the package-manager members that Nx-mode discovery didn't already cover. Dedup is by project root and by name, and
project.jsonwins (itsProjectis kept; the workspace member is only added when neither its root nor its name is already known).Single-file change in
src/workspace/mod.rs; reuses the existingworkspaces::is_workspace/workspaces::get_projectsgeneric loader.Relationship to #77
The merged members come from the generic workspace loader, whose roots are only correct after #77 (
fix(workspace): keep generic-loader project roots workspace-relative). This PR compiles and its unit tests pass independently, but for the merge to actually attribute the extra members at runtime, #77 needs to land too. Recommend merging #77 first (or both together).Verification
cargo test— all workspace unit tests pass (30/30).🤖 Generated with Claude Code