Feature/lunchmeeting fincken#615
Closed
edwinm wants to merge 7 commits into
Closed
Conversation
anneke
previously approved these changes
May 22, 2026
Forces Chrome to be cached at ./.cache/puppeteer (project-scoped) so the install path matches the runtime lookup path and Netlify's build cache picks it up between builds. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Netlify sets PUPPETEER_SKIP_DOWNLOAD=true in the build environment, and that env var takes precedence over .puppeteerrc.cjs in puppeteer's getConfiguration. install.mjs was silently skipping the download, so puppeteer-core couldn't find Chrome at runtime. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
puppeteer's bundled install.mjs is fragile on Netlify: it respects PUPPETEER_SKIP_DOWNLOAD (which Netlify sets to true by default) and it fails to await downloadBrowsers, so errors are swallowed. Invoke the @puppeteer/browsers CLI directly with the pinned Chrome version and cache path, and list the cache contents so the next failure mode is visible in the build log. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Member
Author
|
Replaced by #618 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New lunchmeetin in june with Ramon Fincken