Skip to content

reactphp ^0.7 || ^1.0 || ^1.1 compatibility#53

Open
phiamo wants to merge 12 commits into
friends-of-reactphp:masterfrom
phiamo:master
Open

reactphp ^0.7 || ^1.0 || ^1.1 compatibility#53
phiamo wants to merge 12 commits into
friends-of-reactphp:masterfrom
phiamo:master

Conversation

@phiamo

@phiamo phiamo commented Mar 16, 2020

Copy link
Copy Markdown
  • Bump react deps to 1.1.* (@phiamo)
  • combined the in 0.6.0 existing ReadableStream and WritableStream
    into the now also final InputStream and OutputStream classes
  • adapted the cancelTimer API change in Client

All Unit tests are green!

@clue clue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phiamo Thanks for looking into this! Looks good to me overall, only added some minor remarks below :shipit:

Comment thread composer.json Outdated
Comment thread tests/React/Tests/Stomp/ClientTest.php Outdated
Comment thread tests/React/Tests/Stomp/ClientTest.php Outdated
@phiamo

phiamo commented Nov 8, 2020

Copy link
Copy Markdown
Author

just saw i resolved your comments a while ago @clue

@clue

clue commented Jan 25, 2021

Copy link
Copy Markdown
Contributor

@phiamo Thanks for the update!

Can you look into the failing test cases? I haven't looked into this yet, but it looks like this did work previously (as of #54)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants