upstream fixes, simplified controller resolving#5
Open
digitalkaoz wants to merge 6 commits into
Open
Conversation
Contributor
|
Using symfony request/response here basically eliminates the advantage of using react in the first place, which is the ability to stream responses. Also, please note that this project is a proof of concept and not really intended for production use. |
Author
|
the react request and reponse objects are still available as request attributes. most of the time you wont stream line by line, but if your willing to you can. and yes i know its a POC ;) but i really like how easy it is to switch your silex app to a react socket approach (and see 5times the speed ;) ) with this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed
composer depsnow the controllers stay untouched, it means normal symfony request and response.
the converting is done in the application itself.
although the react request/response are available as request attributes.