macOS cache#770
Conversation
|
Thanks, will do a review when I get the time (sometime this week). |
|
Did a quick test of d076942, and it "fixes" the main cache issue on macOS, but it's still a weird one and I still don't know the rot of the issue, anyway a good workaround 👍 I think we just run Will check the rest later. |
|
it sounds great! |
|
I cherry-picked d076942 to |
|
I took two changes from videoencoder.cpp into this 13b5c1b |
|
Regarding the disk cache changes, I will not add them. Why? first off we don't use the code, and they may look logical, but they will actually break the (non-functional) disk cache. But this made me look more into the disk cache code we have (unfinished code from enve), and I'm able to get it functional with some bugs. So in a future release we can enable disk cache (when the bugs are fixed), it will work as a memory offload when too much RAM is used. I capped Friction to ~600Mb RAM and was able to playback whatever (as long as I had disk space). |
|
Great, it sounds like a plan 🥳 may we close this then? |
|
I can take a look at the last macOS change first, the memory fallback. Will have to wait until I'm using my mac (mostly using Linux at work). |
Hi @rodlie,
I've been trying to improve the experience of working with video within Friction under macOS. I used IA to see if it could do it and, after some tests I think it got better.
Have a look at the code and get the ideas, it may have fixed/improved some issues:
I hope it helps☺️