Skip to content

Update minimum versions for many dependencies - #885

Closed
shsms wants to merge 2 commits into
frequenz-floss:v1.x.xfrom
shsms:numpy
Closed

Update minimum versions for many dependencies#885
shsms wants to merge 2 commits into
frequenz-floss:v1.x.xfrom
shsms:numpy

Conversation

@shsms

@shsms shsms commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

This can be merged after v1-rc5, so that we'll have some more time to look for issues.

dependency from to
google-api-python-client 2.71 2.119.0
grpcio, grpcio-tools 1.54.2 1.62.0
protobuf 4.21.6 4.25.3
networkx 2.8 3.2.1
numpy 1.24.2 1.26.4
pydantic 2.3 2.6.2
timezonefinder 6.2.0 6.4.1
typing_extensions 4.6.1 4.10.0
watchfiles 0.15.0 0.21.0

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
| dependency               | from   | to      |
|--------------------------|--------|---------|
| google-api-python-client | 2.71   | 2.119.0 |
| grpcio, grpcio-tools     | 1.54.2 | 1.62.0  |
| protobuf                 | 4.21.6 | 4.25.3  |
| networkx                 | 2.8    | 3.2.1   |
| numpy                    | 1.24.2 | 1.26.4  |
| pydantic                 | 2.3    | 2.6.2   |
| timezonefinder           | 6.2.0  | 6.4.1   |
| typing_extensions        | 4.6.1  | 4.10.0  |
| watchfiles               | 0.15.0 | 0.21.0  |

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
@shsms
shsms requested a review from a team as a code owner February 26, 2024 14:10
@github-actions github-actions Bot added the part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) label Feb 26, 2024
@shsms

shsms commented Feb 26, 2024

Copy link
Copy Markdown
Contributor Author

Will add release notes after rc5 has been released and the release notes cleared.

@llucax

llucax commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

Why are you bumping minimum dependencies? It is usually a bad idea to do so unless it is strictly necessary, otherwise it is just a breaking change to downstream projects without any real gain. For libraries we should keep supported version ranges as wide as possible.

@shsms

shsms commented Feb 26, 2024

Copy link
Copy Markdown
Contributor Author

For some of them, because it was not running under python 3.12 otherwise. But maybe you're right. I'll just do local hacks for now.

@shsms shsms closed this Feb 26, 2024
@shsms
shsms deleted the numpy branch February 26, 2024 15:12
@llucax

llucax commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

OK, yeah, starting to test against Python 3.12 is on my TODO list, but I guess a bit down in the priority list. I think it makes sense to delay this also until then 👍

@llucax llucax added this to the Dropped milestone Feb 26, 2024
@llucax llucax added the resolution:wontfix This will not be worked on label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) resolution:wontfix This will not be worked on

Projects

Development

Successfully merging this pull request may close these issues.

2 participants