Drop support for Python versions older than 3.11 - #401
Merged
Conversation
leandro-lucarella-frequenz
added
the
type:tech-debt
github-actions
Bot
added
part:data-pipeline
Marenz
previously approved these changes
May 23, 2023
leandro-lucarella-frequenz
force-pushed
the
py311
branch
3 times, most recently
from
May 23, 2023 14:16
6cde981 to
51f1760
Compare
leandro-lucarella-frequenz
enabled auto-merge
May 23, 2023 14:24
Contributor
Author
|
Test were failing, now they should be fixed, so this needs one more approval. Enabled auto-merge. |
Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
Also remove version-specific classifiers in `pyproject.toml` as we are already specifying the supported Python versions in `requires-python`. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
We now also make the Sample3Phase.map() method more generic, to return the same type as self. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
The Sample object implemented comparisons by only comparing timestamps. This was only done to cope with a limitation of `bisect()` before Python 3.10 (where no key argument could be passed). Now that we are using Python 3.11 as the minimal version, we can remove that hack and make Samples compare using both the datetime and the value as one would expect. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
leandro-lucarella-frequenz
force-pushed
the
py311
branch
from
May 23, 2023 14:26
51f1760 to
b21841d
Compare
leandro-lucarella-frequenz
disabled auto-merge
May 23, 2023 14:26
leandro-lucarella-frequenz
enabled auto-merge
May 23, 2023 14:27
Marenz
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyproject.tomlusingtaploFixes #148, fixes #399.