Skip to content

Add ringbuffer memory benchmark - #278

Merged
mathias-baumann-frequenz merged 3 commits into
frequenz-floss:v0.x.xfrom
mathias-baumann-frequenz:ringbuffer-mem
Apr 6, 2023
Merged

Add ringbuffer memory benchmark#278
mathias-baumann-frequenz merged 3 commits into
frequenz-floss:v0.x.xfrom
mathias-baumann-frequenz:ringbuffer-mem

Conversation

@mathias-baumann-frequenz

@mathias-baumann-frequenz mathias-baumann-frequenz commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

Signed-off-by: Mathias L. Baumann mathias.baumann@frequenz.com

@mathias-baumann-frequenz
mathias-baumann-frequenz requested a review from a team as a code owner March 29, 2023 11:03
@mathias-baumann-frequenz mathias-baumann-frequenz added this to the v0.20.0 milestone Mar 29, 2023
@mathias-baumann-frequenz mathias-baumann-frequenz linked an issue Mar 29, 2023 that may be closed by this pull request
Benchmark ringbuffer memory usage #217
Closed
@mathias-baumann-frequenz

mathias-baumann-frequenz commented Mar 29, 2023

Copy link
Copy Markdown
Contributor Author

Some example results:

size:  300
iterations:  1000
gap_size:  0
Allocations since ringbuffer creation:
[ Top 10 ]
/usr/lib64/python3.11/tracemalloc.py:560: size=320 B (+320 B), count=2 (+2), average=160 B
/usr/lib64/python3.11/tracemalloc.py:423: size=320 B (+320 B), count=2 (+2), average=160 B
/home/marenz/frequenz/frequenz-sdk-python/src/frequenz/sdk/timeseries/_ringbuffer.py:269: size=320 B (+320 B), count=2 (+2), average=160 B
/home/marenz/frequenz/frequenz-sdk-python/src/frequenz/sdk/timeseries/_ringbuffer.py:374: size=80 B (+80 B), count=2 (+2), average=40 B
/home/marenz/frequenz/frequenz-sdk-python/src/frequenz/sdk/timeseries/_ringbuffer.py:139: size=80 B (+80 B), count=2 (+2), average=40 B
/home/marenz/frequenz/frequenz-sdk-python/benchmarks/timeseries/ringbuffer_memusage.py:69: size=72 B (+72 B), count=1 (+1), average=72 B
/home/marenz/frequenz/frequenz-sdk-python/src/frequenz/sdk/timeseries/_ringbuffer.py:250: size=48 B (+48 B), count=1 (+1), average=48 B
/home/marenz/frequenz/frequenz-sdk-python/benchmarks/timeseries/ringbuffer_memusage.py:73: size=32 B (+32 B), count=1 (+1), average=32 B
/home/marenz/frequenz/frequenz-sdk-python/src/frequenz/sdk/timeseries/_ringbuffer.py:297: size=16 B (+16 B), count=1 (+1), average=16 B
/home/marenz/frequenz/frequenz-sdk-python/benchmarks/timeseries/ringbuffer_memusage.py:63: size=2536 B (+0 B), count=3 (+0), average=845 B

size:  300
iterations:  1000
gap_size:  2
Allocations since ringbuffer creation:
[ Top 10 ]
/home/marenz/frequenz/frequenz-sdk-python/src/frequenz/sdk/timeseries/_ringbuffer.py:275: size=12.5 KiB (+12.5 KiB), count=300 (+300), average=43 B
/home/marenz/frequenz/frequenz-sdk-python/src/frequenz/sdk/timeseries/_ringbuffer.py:374: size=4000 B (+4000 B), count=100 (+100), average=40 B
/home/marenz/frequenz/frequenz-sdk-python/src/frequenz/sdk/timeseries/_ringbuffer.py:297: size=3120 B (+3120 B), count=97 (+97), average=32 B
/usr/lib64/python3.11/tracemalloc.py:560: size=320 B (+320 B), count=2 (+2), average=160 B
/usr/lib64/python3.11/tracemalloc.py:423: size=320 B (+320 B), count=2 (+2), average=160 B
/home/marenz/frequenz/frequenz-sdk-python/benchmarks/timeseries/ringbuffer_memusage.py:69: size=72 B (+72 B), count=1 (+1), average=72 B
/home/marenz/frequenz/frequenz-sdk-python/src/frequenz/sdk/timeseries/_ringbuffer.py:250: size=48 B (+48 B), count=1 (+1), average=48 B
/home/marenz/frequenz/frequenz-sdk-python/src/frequenz/sdk/timeseries/_ringbuffer.py:139: size=40 B (+40 B), count=1 (+1), average=40 B
/home/marenz/frequenz/frequenz-sdk-python/benchmarks/timeseries/ringbuffer_memusage.py:73: size=32 B (+32 B), count=1 (+1), average=32 B
/home/marenz/frequenz/frequenz-sdk-python/benchmarks/timeseries/ringbuffer_memusage.py:63: size=2536 B (+0 B), count=3 (+0), average=845 B

size:  90
iterations:  1000
gap_size:  5
Allocations since ringbuffer creation:
[ Top 10 ]
/home/marenz/frequenz/frequenz-sdk-python/src/frequenz/sdk/timeseries/_ringbuffer.py:275: size=1920 B (+1920 B), count=45 (+45), average=43 B
/home/marenz/frequenz/frequenz-sdk-python/src/frequenz/sdk/timeseries/_ringbuffer.py:374: size=600 B (+600 B), count=15 (+15), average=40 B
/home/marenz/frequenz/frequenz-sdk-python/src/frequenz/sdk/timeseries/_ringbuffer.py:297: size=416 B (+416 B), count=13 (+13), average=32 B
/usr/lib64/python3.11/tracemalloc.py:560: size=320 B (+320 B), count=2 (+2), average=160 B
/usr/lib64/python3.11/tracemalloc.py:423: size=320 B (+320 B), count=2 (+2), average=160 B
/home/marenz/frequenz/frequenz-sdk-python/benchmarks/timeseries/ringbuffer_memusage.py:69: size=72 B (+72 B), count=1 (+1), average=72 B
/home/marenz/frequenz/frequenz-sdk-python/src/frequenz/sdk/timeseries/_ringbuffer.py:250: size=48 B (+48 B), count=1 (+1), average=48 B
/home/marenz/frequenz/frequenz-sdk-python/src/frequenz/sdk/timeseries/_ringbuffer.py:139: size=40 B (+40 B), count=1 (+1), average=40 B
/home/marenz/frequenz/frequenz-sdk-python/benchmarks/timeseries/ringbuffer_memusage.py:73: size=32 B (+32 B), count=1 (+1), average=32 B
/home/marenz/frequenz/frequenz-sdk-python/benchmarks/timeseries/ringbuffer_memusage.py:63: size=856 B (+0 B), count=3 (+0), average=285 B

@mathias-baumann-frequenz
mathias-baumann-frequenz force-pushed the ringbuffer-mem branch 3 times, most recently from 54e397e to 128d87f Compare March 30, 2023 16:06
daniel-zullo-frequenz
daniel-zullo-frequenz reviewed Apr 6, 2023
View reviewed changes
Comment thread benchmarks/timeseries/ringbuffer_memusage.py Outdated
daniel-zullo-frequenz
daniel-zullo-frequenz reviewed Apr 6, 2023
View reviewed changes
Comment thread benchmarks/timeseries/ringbuffer_memusage.py
daniel-zullo-frequenz
daniel-zullo-frequenz reviewed Apr 6, 2023
View reviewed changes
Comment thread benchmarks/timeseries/ringbuffer_memusage.py Outdated
daniel-zullo-frequenz
daniel-zullo-frequenz reviewed Apr 6, 2023
View reviewed changes

@daniel-zullo-frequenz daniel-zullo-frequenz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor comments to check for, LGTM otherwise

@Marenz
Add ringbuffer memory benchmark
a29e18f 
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
@mathias-baumann-frequenz
mathias-baumann-frequenz merged commit fcaff7d into frequenz-floss:v0.x.x Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-zullo-frequenz daniel-zullo-frequenz daniel-zullo-frequenz approved these changes

Assignees

@mathias-baumann-frequenz mathias-baumann-frequenz

Labels

None yet

Projects

Python SDK Roadmap
Status: Done

Milestone

v0.20.0

Development

Successfully merging this pull request may close these issues.

Benchmark ringbuffer memory usage

3 participants

@mathias-baumann-frequenz @daniel-zullo-frequenz @Marenz