Write INFO logs for components transitioning to WORKING state - #1277
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR changes the log level for component status transitions from NOT_WORKING to WORKING state from WARNING to INFO level. This adjustment better reflects that transitioning to a WORKING state is normal operational behavior rather than a warning condition.
- Changed log level from
warningtoinfofor WORKING state transitions - Applied the change consistently across PV inverter and EV charger status trackers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
_pv_inverter_status_tracker.py |
Updated log level to INFO when PV inverter transitions to WORKING state |
_ev_charger_status_tracker.py |
Updated log level to INFO when EV charger transitions to WORKING state |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-actions
Bot
added
the
part:microgrid
d89d011 to
8335a3f
Compare
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
8335a3f to
5d196b4
Compare
| if self._last_status == ComponentStatusEnum.NOT_WORKING: | ||
| _logger.warning( | ||
| _logger.info( | ||
| "EV charger %s is in WORKING state.", |
There was a problem hiding this comment.
Wouldn't it make sense to also say it's becoming functional after being not working? Or at least say "changed state to WORKING` or something like that, saying more explicit it is a state change?
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
5d196b4 to
77a0984
Compare
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
77a0984 to
f207266
Compare
Marenz
left a comment
Marenz
left a comment
There was a problem hiding this comment.
I personally hate the release notes update in an extra commit 😆
github-project-automation
Bot
moved this from To do
to Review approved
in Python SDK Roadmap
|
Any nasty trick to stay ahead of @llucax: https://github.com/frequenz-floss/frequenz-sdk-python/graphs/contributors \o/ |
github-project-automation
Bot
moved this from Review approved
to Done
in Python SDK Roadmap
No description provided.