Change consumer power formula to add 0 if meter is not sending data - #1016
Closed
ela-kotulska-frequenz wants to merge 1 commit into
Closed
Change consumer power formula to add 0 if meter is not sending data#1016ela-kotulska-frequenz wants to merge 1 commit into
ela-kotulska-frequenz wants to merge 1 commit into
Conversation
ela-kotulska-frequenz
requested review from
shsms
and removed request for
a team
August 1, 2024 10:55
Previously if any meter stopped working, we didn't get any power from formula. We need to keep application working even if meter is not responding. This field should be configurable in the future. Another feature might be to fallback to successor components. Signed-off-by: Elzbieta Kotulska <elzbieta.kotulska@frequenz.com>
ela-kotulska-frequenz
force-pushed
the
fix
branch
from
August 1, 2024 11:00
d775702 to
603e39c
Compare
ela-kotulska-frequenz
changed the title
ela-kotulska-frequenz
marked this pull request as draft
August 1, 2024 11:05
Contributor
Author
|
Done with fallback formulas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if any meter stopped working, we get None from whole formula.
We need to keep application working even if meter is not sending data.
This field should be configurable in the future.
Another feature might be to fallback to successor components.