Inherit value errors from a new InvalidAttributeError - #247
Merged
Conversation
llucax
force-pushed
the
invalid-attr-error
branch
from
July 9, 2026 12:28
3e1cea5 to
ffe337a
Compare
github-actions
Bot
added
part:tests
llucax
added
the
cmd:skip-release-notes
llucax
force-pushed
the
invalid-attr-error
branch
from
July 9, 2026 13:00
95d0ec4 to
9953c5b
Compare
llucax
marked this pull request as ready for review
July 9, 2026 13:01
llucax
enabled auto-merge
July 9, 2026 13:01
llucax
force-pushed
the
invalid-attr-error
branch
2 times, most recently
from
July 9, 2026 13:39
6c2164a to
086581a
Compare
This exception will be the base for any exception raised when an attribute that holds invalid data is accessed through a semantic accessor. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Make `UnrecognizedEnumValueError` and `UnspecifiedEnumValueError` inherit from `InvalidAttributeError`. Also split exception tests as the file grew too much when adding the new tests. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Add a new top-level exception `MissingFieldError`, sibling of `UnspecifiedEnumValueError`, to signal that a semantic accessor was called on a wrapper field that resolves to `None` because the underlying field was not set on the wire. The first user is the upcoming `Microgrid.get_delivery_area()` accessor (delivery area may be `None`, `InvalidDeliveryArea`, or `DeliveryArea`), but the pattern is expected to recur wherever an accessor unifies a `T | ... | None` field into a plain `T` return. Like `Unspecified/UnrecognizedEnumValueError`, it multi-inherits from `ClientCommonError` and `ValueError` for convenience. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
llucax
force-pushed
the
invalid-attr-error
branch
from
July 10, 2026 13:21
086581a to
00b8b76
Compare
Marenz
approved these changes
Jul 13, 2026
Marenz
left a comment
Marenz
left a comment
Contributor
There was a problem hiding this comment.
🤖 No blocking findings. Minor residual risk: the accessor tests do not explicitly assert the exceptions' instance and attr_name metadata, but this is not approval-blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we continue to add more exception that are intended for reporting invalid data in attributes, it makes sense to have a parent class with the shared attributes for all of them.
This PR adds a new
InvalidAttributeErrorexception and makes all existing value errors inherit from it.Also adds a new
MissingFieldErrorin preparation for upcoming PRs.Part of #239.