fix: require auth for subscriber APIs to prevent unauthenticated access#211
Open
carlhus wants to merge 2 commits into
Open
fix: require auth for subscriber APIs to prevent unauthenticated access#211carlhus wants to merge 2 commits into
carlhus wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(webconsole): require auth for subscriber APIs to prevent unauthenticated access (#1069)
This PR fixes issue #1069 in WebConsole subscriber management.
It prevents unauthenticated users from reading, modifying, or deleting subscriber records via subscriber APIs.
Root cause: the /api route group did not have a global authentication middleware, and several subscriber handlers relied on per-handler checks that were missing or incomplete.
Changes: Add JWT authentication middleware to the /api route group.
Allow unauthenticated POST /api/login and OPTIONS preflight requests.
Store parsed JWT claims, tenant ID, and admin status in Gin context.
Enforce tenant ownership before subscriber GET/PUT/PATCH/DELETE operations.
Stop using nil JWT claims when updating or deleting subscriber records.
This is reported in GitHub Issue #1069.