feat(slice-008): add list mode, edit holding, and delete holding#9
Merged
Merged
Conversation
- Add listing, editingAmount, and deleting mode types to PortfolioModel - Add holdingsCursor and scrollOffset fields for list navigation - Implement browsing mode Enter key to enter list mode - Add PgUp/PgDn for preview scrolling in browsing mode - Implement listing mode with j/k/g/G navigation, Enter to edit, X to delete - Add edit amount dialog with pre-populated current amount - Add delete confirmation dialog - Implement cmdDeleteHolding and cmdUpdateHoldingAmount commands - Update View() with panel border highlighting (accent for focused panel) - Update InputActive() to include editingAmount mode - Update status bar hints for all new modes - Add 40+ tests for list mode, edit, delete, and scrolling functionality All checks pass: make check + make build successful.
…ns to browsing instead of listing Closes finding F1 in docs/reviews/008-list-mode-edit-delete-holding/revision-1.md
…shortcuts Closes finding I2 in docs/reviews/008-list-mode-edit-delete-holding/revision-1.md Revision status: done
fredericomozzato
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enterfrom menu mode to enter list mode (right panel focus),Escreturns to menuj/k/g/Gnavigation in holdings listEnteron holding to edit amount (pre-populated dialog)Xon holding to delete with confirmation dialogPgUp/PgDnpreview scrolling from menu modeTest Plan
Enterfrom menu mode enters list mode with focus on right panelEscfrom list mode returns to menu modej/k/g/Gnavigate holdings in list modeEnteron a holding opens edit amount dialog pre-populated with current amountXon a holding opens delete confirmation dialogPgUp/PgDnscroll the right panel preview from menu mode