feat(slice-006): create portfolio left panel with navigation and create dialog#7
Merged
Merged
Conversation
Closes findings I1 and I2 in docs/reviews/006-create-portfolio-left-panel/revision-1.md - I1: Implement overlayDialog helper to show panels behind dialog - I2: Remove unused height parameter from renderRightPanel
…d width calculations - I1: Fixed contentHeight to account for border rows (m.height - 3) - I2: Replaced byte-level overlayDialog with lipgloss.Place centered dialog - I3: Fixed panel width calculations using outer/inner width distinction Closes findings I1, I2, I3 in docs/reviews/006-create-portfolio-left-panel/revision-2.md
- I1 (HIGH): Fan out background messages to both child models in app.go so portfoliosLoadedMsg is not dropped when Markets tab is active. - I2 (LOW): Add 'Portfolios' and 'Holdings' titles to left and right panels. - Added tests for both behaviors: * TestBackgroundMessagesFannedOutToBothChildren * TestPanelTitlesDisplayed Closes findings I1, I2 in docs/reviews/006-create-portfolio-left-panel/revision-3.md
Closes finding I1 in docs/reviews/006-create-portfolio-left-panel/revision-4.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreatePortfolio,GetAllPortfolios) with full SQLite tests▶cursor,j/knavigation, and reverse-video highlightEntersaves,Esccancels) usinglipgloss.Placefor centered overlayBug Fixes (discovered during review)
Panel layout:
contentHeight := m.height - 3)m.width + 3, causing horizontal overflowrenderLeftPanelreceivingcontentHeight-2— border offset already handled by lipgloss, hiding 2 panel rows unnecessarilyDialog:
renderDialogOverlayignoring itsbackgroundparameter (panels vanished behind dialog)overlayDialogcorrupting dialog layout; replaced withlipgloss.PlaceData loading:
portfoliosLoadedMsgbeing dropped when Markets tab is active on startup; background messages are now fanned out to both child models inapp.goCleanup:
heightparameter fromrenderRightPanelTest Plan
go test -race -v ./internal/store/... -run "Portfolio"→ 5 tests PASSgo test -race -v ./internal/ui/... -run "Portfolio"→ 23 tests PASSgolangci-lint run ./...→ no issuesj/k, cursor highlights full row widthnto open create dialog,Entersaves,Esccancels