feat(slice-005): tab bar + empty Portfolio tab#6
Merged
Conversation
- Refactor AppModel into thin root/router model with tab switching - Extract MarketsModel with all markets-specific state and logic - Add PortfolioModel with empty state placeholder - Implement tab bar rendering with active/inactive styling - Add Tab/Shift+Tab/1/2 for tab navigation - Add global q/Ctrl+C quit handling - Suppress tab switching when child input is active (InputActive method) - Propagate WindowSizeMsg to children with height-1 for tab bar - Add comprehensive tests for all new functionality
…x skill - Move docs/reviews/NNN-name.md → docs/reviews/NNN-name/revision-1.md for all 4 slices - Update 005 revision-1 frontmatter: status open → in_progress (new lifecycle) - Add .claude/skills/fix/SKILL.md: resolves OPEN findings highest-severity first, each fix is one atomic commit, gates on make check, marks revision done when complete - Update .claude/skills/qa/SKILL.md: create per-revision files instead of appending, status lifecycle: in_progress → done (fix) | passed (clean qa) Status lifecycle: in_progress → done | passed Token benefit: fix skill reads only the in_progress revision file, never loads history Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…consolidate duplicate test context vars Closes findings I1 and I2 in docs/reviews/005-tab-bar-empty-portfolio-tab/revision-1.md
…onfirmed Clean qa pass leaves no file — last done revision stands as audit record. Revision file is only created when findings exist (status: in_progress). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppModelbecomes a lean root/router; all markets logic extracted toMarketsModelinmarkets.goPortfolioModel(empty state: "no portfolios — press n to create one")Tab/Shift+Tab/1/2; suppressed whenInputActive()returns trueTest Plan
make checkpasses — gofumpt clean, golangci-lint 0 issues, all tests race-clean, govulncheck cleanAppModeltests: tab switching, quit, window size propagationMarketsModeltests: cursor, refresh, tick, status bar, load/seed logicPortfolioModeltests: empty state, window size, input suppressionMarketsModel.View(), consolidated duplicatecontext.Background()test vars🤖 Generated with Claude Code