fix(slice-011): code correctness and clarity improvements#12
Merged
Conversation
- Fix ignored io.ReadAll errors in coingecko.go FetchMarkets and FetchPrices - Add named constants for magic numbers in markets.go (coinFetchLimit, refreshInterval) - Add cancellation safety comment in main.go - Add DB lifecycle ownership comment in main.go - Add broadcast pattern explanation comment in app.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
io.ReadAllerrors ininternal/api/coingecko.go— bothFetchMarketsandFetchPricesnow propagate read errors from non-2xx response bodies instead of ignoring theminternal/ui/markets.go—coinFetchLimit(100),refreshInterval(60s), grouped alongside existingstaleThresholdcmd/crypto-tracker/main.go— cancellation safety assumption for shutdown and DB lifecycle ownershipinternal/ui/app.goTest Plan
make checkpasses (fmt, lint, test, vuln)