feat(slice-009): portfolio edit and delete#10
Merged
Conversation
…o edit/delete - F1: Friendly error message for duplicate portfolio names with red styling - F2: Fixed width dialogs for create/edit portfolio (proportional sizing) - F3: Removed 'a' key from browsing mode (list-mode only for add holding) - F4: Enter key now enters holdings panel even when portfolio is empty - C1: Added TestUniquePortfolioName to verify schema UNIQUE constraint Closes findings F1-F4, C1 in docs/reviews/009-portfolio-edit-delete/revision-1.md
- Add RenamePortfolio and DeletePortfolio to Store interface - Implement both methods in SQLiteStore with proper error wrapping - Add UNIQUE constraint on portfolios.name in schema - Cover new methods with tests: happy path, duplicate name, not found, cascade delete - Update StubStore in UI tests to satisfy new interface - Update roadmap: mark slice 9 done, renumber slice 10 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e) and delete portfolio (X) interactions in the portfolio panelRenamePortfolioandDeletePortfolioto theStoreinterface andSQLiteStoreimplementationUNIQUEconstraint onportfolios.nameto enforce uniqueness at the DB levelTest Plan
eon a portfolio opens edit dialog pre-filled with current name;Entersaves,EsccancelsXon a portfolio opens delete confirmation;Enterdeletes with holdings,Esccancelsmake testpasses with race detector clean