Convert ANyUrl and HttpUrl to str#62
Merged
jamie-sgro merged 1 commit intoJan 9, 2026
Merged
Conversation
jamie-sgro
approved these changes
Jan 9, 2026
jamie-sgro
left a comment
Member
There was a problem hiding this comment.
Yes, this change makes sense. It was a mistake for us to use Path on a url to begin with. I've spoken about this previously here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
{ "product_name": "MOD13A2", "product_version": "061", "iso3_code": "LBR", "start_date": "2025-07-01", "end_date": "2025-12-31", "data_dir": ".", }AttributeError: 'AnyUrl' object has no attribute 'decode'Checklist:
Next Steps
Assign a reviewer based on the code owner document.
Once your review is approved, merge and delete the feature branch
On behalf of the Modis Tools Dev Team, thank you for your hard work! ✨