feat: Image Fit Options#466
Conversation
Co-authored-by: batonac <4996285+batonac@users.noreply.github.com>
…ze, background-position, and background-repeat to Jinja templates Co-authored-by: batonac <4996285+batonac@users.noreply.github.com>
Co-authored-by: batonac <4996285+batonac@users.noreply.github.com>
|
@batonac this won't work with wkhtmltopdf right ! |
|
we can still merge just want to confirm, this will work with new backend ( chrome) |
|
That may be true, but I'm getting a strange "PDF generation failed because of broken image links" when I try to use wkhtmltopdf as the backend in my local devcontainer development environment. That's true on the main branch or this branch, so I haven't figured it out, but I believe it's totally unrelated to these changes. |
|
To be clear, everything works great with the new chrome backend (all functionality in the develop branch and this branch) in my local testing environment. |
|
@maharshivpatel do you need me to verify the wkhtmltopdf question before we can merge? |
|
Hey @maharshivpatel I was able to verify that the image print options work with both the wkhtmltopdf and chrome rendering backends. |
|
@batonac will try to merge by Tuesday. please feel free to ping if i forget 😅. |
|
Hey @maharshivpatel, Tuesday came and went! 😅 |
|
friendly bump. |
|
Branches wait in wind, |
|
Nice addition! |
|
hey @NagariaHussain anything I can do to move this forward? |
|
@NagariaHussain looking forward to this |
|
Will review and merge after testing 👍 |
|
Hey @NagariaHussain, any chance we could move this forward? It's a relatively light patch but a significant feature for some of us 🙏 |
fixes #465