fix: resolve semgrep findings, add type hints to whitelisted, and remove f-string#1264
Draft
Nihantra-Patel wants to merge 4 commits into
Draft
fix: resolve semgrep findings, add type hints to whitelisted, and remove f-string#1264Nihantra-Patel wants to merge 4 commits into
Nihantra-Patel wants to merge 4 commits into
Conversation
Nihantra-Patel
commented
Jun 8, 2026
Member
- Add type hints to whitelisted/framework API methods
- Convert SQL string queries (.format/f-string) to frappe.qb
- Add frappe.has_permission checks to whitelisted methods that write data
- Replace raw SQL aggregate/arithmetic field strings in get_all/get_value with dict aggregate syntax and frappe.qb
- Declare [tool.bench.frappe-dependencies] (frappe, erpnext) in pyproject.toml
- Remove redundant setup.py (build uses flit_core via pyproject.toml)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.