fix: increase DB write limit before Loan Repayment Repost submission (backport #1260)#1262
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When a Loan Repayment Repost is submitted via Data Import for a loan with a
long history (e.g. repost from 2 years back), the submission fails with:
This happens because the repost cancels and recreates a large number of
accruals, demands, and GL entries in a single transaction, enough to
cross Frappe's default 200,000 write limit.
Fix
Multiply
frappe.db.MAX_WRITES_PER_TRANSACTIONby 4 at the start ofon_submit, raising the ceiling to 800,000 for the duration of therepost.
This is the same approach used in ERPNext for Repost Item Valuation
This is an automatic backport of pull request #1260 done by [Mergify](https://mergify.com).