Skip to content

allow user input node content as HtmlElement#129

Open
Jim-JZ-Chen wants to merge 1 commit into
fperucic:masterfrom
Jim-JZ-Chen:patch-1
Open

allow user input node content as HtmlElement#129
Jim-JZ-Chen wants to merge 1 commit into
fperucic:masterfrom
Jim-JZ-Chen:patch-1

Conversation

@Jim-JZ-Chen

Copy link
Copy Markdown

so user can better modifier the node content

so user can better modifier the node content
@fperucic

Copy link
Copy Markdown
Owner

ok,
please use this.nodeInnerHTML instanceof HTMLElement instead of typeof this.nodeInnerHTML === "string" before using appendChild

We can merge when you make that change.

cheers

@fperucic

Copy link
Copy Markdown
Owner

and it would be nice to add the newly added options to the documentation branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants