Skip to content

fix(user): remove phantom system_status::get API (#377)#412

Merged
foxzool merged 1 commit into
mainfrom
fix/issue-377-system-status-phantom-get
Jul 10, 2026
Merged

fix(user): remove phantom system_status::get API (#377)#412
foxzool merged 1 commit into
mainfrom
fix/issue-377-system-status-phantom-get

Conversation

@foxzool

@foxzool foxzool commented Jul 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • 删除 openlark-user 中飞书目录不存在的幻影 API SystemStatusResource::get() / SystemStatusGetRequest(畸形 URL,调用即失败)。
  • system_status 资源仅保留 6 个真实构建器:list / create / patch / delete / batch_open / batch_close
  • 同步契约测试、文档注释与 CHANGELOG Breaking 条目(v0.18 线)。

Closes #377

Breaking

SystemStatusResource::get()SystemStatusGetRequest 已移除。旧 get 对真实飞书本就 404;请改用 list() / SystemStatusListRequest

Test plan

  • cargo build --workspace --all-features
  • cargo test -p openlark-user --all-features
  • cargo test --workspace --all-features
  • cargo clippy --workspace --all-targets --all-features -- -Dwarnings
  • cargo clippy --workspace --all-targets --no-default-features -- -Dwarnings
  • 全仓 grep:代码中无 SystemStatusGet / system_status::get 残留引用
  • CI 绿灯

Note

Low Risk
Breaking only for code that called the already-nonfunctional get() API; no auth, data, or transport changes.

Overview
Breaking cleanup in openlark-user: removes the phantom Feishu system_status “get” surface that never matched a real API (malformed URL, would 404 on production).

SystemStatusResource::get(), SystemStatusGetRequest / SystemStatusGetResponse, and get.rs (including its wiremock test) are deleted. system_status is documented and wired as six builders only: list, create, patch, delete, batch_open, batch_close. The CHANGELOG moves this from a prior deprecation note to an explicit Breaking entry for the v0.18 line.

Migration: callers that used get() should use list() / SystemStatusListRequest—the old get was not viable against Feishu anyway.

Reviewed by Cursor Bugbot for commit cf1520a. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor

cursor Bot commented Jul 10, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_b765f6bf-43fa-42df-98b8-0bff071f3263)

Feishu personal_settings/v1/system_status has no get endpoint (list is the
list/get equivalent). Delete the broken public get accessor and its malformed
URL builder so the resource exposes only the six real builders.
@foxzool
foxzool force-pushed the fix/issue-377-system-status-phantom-get branch from 1386400 to cf1520a Compare July 10, 2026 04:45
@cursor

cursor Bot commented Jul 10, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_17bac8a6-941f-47ea-8d8e-6962043ad242)

@foxzool
foxzool merged commit 5942490 into main Jul 10, 2026
119 checks passed
@foxzool
foxzool deleted the fix/issue-377-system-status-phantom-get branch July 10, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] openlark-user system_status::get 为幻影 API:实现不存在的接口 + URL 畸形,却暴露为 broken public method

1 participant