Skip to content

Version 0.7.0, namely for better type exports#459

Closed
lewey-foxglove wants to merge 1 commit into
mainfrom
lewey/viz-2411-lintable-type
Closed

Version 0.7.0, namely for better type exports#459
lewey-foxglove wants to merge 1 commit into
mainfrom
lewey/viz-2411-lintable-type

Conversation

@lewey-foxglove

Copy link
Copy Markdown
Contributor

Changelog

Added typed package exports and a public ThreeTextLabel type for TypeScript consumers.

Docs

None

Description

LabelPool.acquire() previously exposed the concrete internal Label class as its public return type. That made downstream consumers depend on more of the package's implementation detail than they actually need, and it can also pull in incompatible local three type identities when this package is linked into another TypeScript project.

This change adds a public structural ThreeTextLabel<TObject3D> type describing the label API consumers use, exports it from the package root, and updates LabelPoolBase.acquire() / release() to use that public type. Consumers that need their local THREE.Object3D identity can provide it as the generic parameter without importing Label internals. The package metadata now declares TypeScript entrypoints for the root and ./webgpu exports, and the package version is bumped to 0.7.0.

Validation:

  • yarn typecheck
  • yarn lint:ci
  • yarn build
  • Also validated in main foxglove app linter and build.

@linear-code

linear-code Bot commented Jun 17, 2026

Copy link
Copy Markdown

VIZ-2411

@jtbandes jtbandes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this isn't needed after all - we can probably close this.

@jtbandes
jtbandes deleted the lewey/viz-2411-lintable-type branch July 9, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants