Version 0.7.0, namely for better type exports#459
Closed
lewey-foxglove wants to merge 1 commit into
Closed
Conversation
jtbandes
requested changes
Jun 18, 2026
jtbandes
left a comment
Member
There was a problem hiding this comment.
Seems like this isn't needed after all - we can probably close this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Added typed package exports and a public
ThreeTextLabeltype for TypeScript consumers.Docs
None
Description
LabelPool.acquire()previously exposed the concrete internalLabelclass as its public return type. That made downstream consumers depend on more of the package's implementation detail than they actually need, and it can also pull in incompatible localthreetype identities when this package is linked into another TypeScript project.This change adds a public structural
ThreeTextLabel<TObject3D>type describing the label API consumers use, exports it from the package root, and updatesLabelPoolBase.acquire()/release()to use that public type. Consumers that need their localTHREE.Object3Didentity can provide it as the generic parameter without importingLabelinternals. The package metadata now declares TypeScript entrypoints for the root and./webgpuexports, and the package version is bumped to0.7.0.Validation:
yarn typecheckyarn lint:ciyarn buildapplinter and build.