Conversation
jtbandes
requested review from
amacneil,
defunctzombie,
jesse-foxglove and
niels-foxglove
February 12, 2026 00:28
defunctzombie
approved these changes
Feb 12, 2026
defunctzombie
left a comment
defunctzombie
left a comment
There was a problem hiding this comment.
What a time to be alive. I guess the file extensions are upon us much to my sadness. Good thing I don't look at code anymore 🙈
| @@ -1,5 +1,5 @@ | |||
| import TinySDF from "@mapbox/tiny-sdf"; | |||
| import { EventDispatcher } from "three"; | |||
| import * as THREE from "three"; | |||
There was a problem hiding this comment.
Does this bloat the final package or downstream bundles of the package?
Member
Author
There was a problem hiding this comment.
The three.js folks are big on tree shaking so I think not. Also they are big on using import * as THREE from 'three'; in all their examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Breaking changes:
Docs
None
Description
Split from #448
@foxglove/tsconfig, replace some TS-specific syntax features, add file extensions on all imports"type": "module", removetsconfig.cjs.json