Skip to content

Performance improvements#7

Closed
defunctzombie wants to merge 1 commit intomainfrom
roman/update-tsconfig-target
Closed

Performance improvements#7
defunctzombie wants to merge 1 commit intomainfrom
roman/update-tsconfig-target

Conversation

@defunctzombie
Copy link
Copy Markdown

Changelog

Docs

Description

BeforeAfter

@defunctzombie
Copy link
Copy Markdown
Author

Another thing I noticed is that we should drop the { id, ...msg } altogether. We know the fields of the container and the payload should be separate and we don't need to spread it. These are small things in the scheme of things but its also equally easy to read and write the code doing it the way that does less work. If there was a benefit to the more work approach then sure - but in the current approach it is strictly more work for no reason.

@defunctzombie
Copy link
Copy Markdown
Author

GoogleChromeLabs#654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant