Convert roll requests into bespoke system sub-type. - #7285
Open
Fyorl wants to merge 1 commit into
Open
Conversation
Fyorl
commented
Jul 28, 2026
arbron
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No migration for this one. Roll requests didn't write a
roll.typeflag and I didn't want a heuristic check, so I think these cards will just remain unmigrated and eventually their click handlers will stop being applied but I don't foresee that being a problem for these types of cards.I also opted for
promptoverrollRequestpartly because I am biased against camelCase property names in general, and partly because we had co-opted this message type for the end concentration prompt, which is not a request for a roll. I figured it might be more generally useful to have a card that will accept extensible data for prompting for various game actions.I also considered whether this should be unified with the
requestcard in some way, since they can both request rolls, but therequestcard has specific targets rather being broadcast for anyone to optionally roll, and it is also stateful, unlike this card.