Coerce strings that look like bools or numbers into booleans or numbers when applying unguided AEs - #7258
Open
krbz999 wants to merge 1 commit into
Conversation
…rs when applying unguided AEs
Fyorl
added
feature request
api
system: active effects
priority: low
strategic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, using
flags.world.foo | override | trueresults inActor#flags.world.foo === "true"and similar applies when using numeric-like values.This changes it such that if the change is unguided (not targeting a datafield) but target
flags, it is attempted to be coerced into a boolean or number.This helps with the new conditionals as currently something like this is not possible:
and a different change with
(Note: in conjunction with #7257)