Clean up updateDowned by using fromStatusEffect - #7249
Open
roth-michael wants to merge 1 commit into
Open
Conversation
Contributor
|
Forcing Maybe a setting for both statuses overlay behaviour would be better received? PS: Probably not the best spot to discuss that, but oh well, if needed I can split to a new issue? |
Fyorl
added
system: active effects
priority: high
uncontroversial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor improvement, but a good one I think. Any calls to
updateDownedwere already beingawaited, so the change toasyncisn't impactful. UsingfromStatusEffectinstead of manually recreating the results of it twice (once for each condition) saves some lines of code, and means less tech debt if there are any future changes to the way we'd want to create such an effect.