Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix potential local code execution via git config#76

Open
tachyon-beep wants to merge 1 commit into
mainfrom
sentinel/fix-git-local-code-execution-18415563806124433476
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix potential local code execution via git config#76
tachyon-beep wants to merge 1 commit into
mainfrom
sentinel/fix-git-local-code-execution-18415563806124433476

Conversation

@tachyon-beep

Copy link
Copy Markdown
Collaborator

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Invoking git via subprocess against potentially untrusted directories could lead to local code execution via malicious .git/config files (specifically through features like core.fsmonitor).
🎯 Impact: An attacker could execute arbitrary commands by placing a malicious .git/config file in a directory that the wardline scanner operates on.
πŸ”§ Fix: Propagated the _SAFE_GIT_CONFIG = ("-c", "core.fsmonitor=false") pattern (already used in attest.py) to all other modules making git subprocess calls (delta.py and legis.py).
βœ… Verification: Ran the test suite (make test), formatted and linted the code. Added a journal entry to .jules/sentinel.md documenting this finding.


PR created automatically by Jules for task 18415563806124433476 started by @tachyon-beep

Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant