Skip to content

base: switch to upstream INCOMPATIBLE_LICENSE#1618

Merged
quaresmajose merged 5 commits intofoundriesio:mainfrom
quaresmajose:gplv3
Jan 26, 2026
Merged

base: switch to upstream INCOMPATIBLE_LICENSE#1618
quaresmajose merged 5 commits intofoundriesio:mainfrom
quaresmajose:gplv3

Conversation

@quaresmajose
Copy link
Copy Markdown
Member

@quaresmajose quaresmajose commented Apr 7, 2025

Tested with the following snip in the conf/local.conf

- Recipe with exclusive LICENSE

require conf/distro/include/lmp-no-gplv3.inc
# ../openembedded-core/meta/recipes-extended/bash/bash_5.2.21.bb:LICENSE = "GPL-3.0-or-later"
IMAGE_INSTALL:append = " bash"

The above config will result in the following error as expected:

$ bitbake lmp-base-console-image
ERROR: lmp-base-console-image-1.0-r0 do_rootfs: Package bash cannot be installed into the image because it has incompatible license(s): LGPL-3.0-or-later

- Recipe with or LICENSE

require conf/distro/include/lmp-no-gplv3.inc
# ../openembedded-core/meta/recipes-support/gmp/gmp_6.3.0.bb:LICENSE = "GPL-2.0-or-later | LGPL-3.0-or-later"
IMAGE_INSTALL:append = " gmp"

The above config will not generate any error

$ bitbake lmp-base-console-image

@quaresmajose
Copy link
Copy Markdown
Member Author

quaresmajose commented Apr 7, 2025

This PR requires additional changes on the ci-scripts to change the handling of the DISABLE_GPLV3 and also on the documentations side https://docs.foundries.io/latest/reference-manual/linux/linux-oss-compliance.html

@quaresmajose quaresmajose requested a review from a team April 7, 2025 13:51
quaresmajose added a commit to quaresmajose/ci-scripts that referenced this pull request Apr 7, 2025
@quaresmajose
lmp/bb-config: add v95 no-gplv3 config
5236f6e 
With the v95 we droped the image-license-checker and lmp-disable-gplv3 bbclass.
foundriesio/meta-lmp#1618

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
@quaresmajose quaresmajose mentioned this pull request Apr 7, 2025
Merged
@quaresmajose
Copy link
Copy Markdown
Member Author

quaresmajose commented Apr 7, 2025

This PR requires additional changes on the ci-scripts to change the handling of the DISABLE_GPLV3 and also on the documentations side https://docs.foundries.io/latest/reference-manual/linux/linux-oss-compliance.html

ci-scripts adaptation foundriesio/ci-scripts#380

@quaresmajose quaresmajose marked this pull request as draft April 8, 2025 10:19
@quaresmajose quaresmajose self-assigned this Apr 8, 2025
@quaresmajose quaresmajose marked this pull request as ready for review May 6, 2025 11:14
quaresmajose added a commit to quaresmajose/ci-scripts that referenced this pull request Jun 23, 2025
@quaresmajose
lmp/bb-config: add v95 no-gplv3 config
58a20ec 
With the v95 we droped the image-license-checker and lmp-disable-gplv3 bbclass.
foundriesio/meta-lmp#1618

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
angolini
angolini approved these changes Jun 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@angolini angolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only few suggestions

Comment thread meta-lmp-base/conf/distro/include/lmp-no-gplv3.inc Outdated
quaresmajose added a commit to quaresmajose/ci-scripts that referenced this pull request Jun 24, 2025
@quaresmajose
lmp/bb-config: add support to the new lmp no-gplv3 config
11d8e26 
With [1] we droped the bitbake image-license-checker and lmp-disable-gplv3 bbclass.
So add support to the new lmp no-gplv3 config.

[1] foundriesio/meta-lmp#1618

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
@quaresmajose
Copy link
Copy Markdown
Member Author

quaresmajose commented Jul 3, 2025 •
edited
Loading

we need to first merge foundriesio/ci-scripts#380

@quaresmajose
base: lmp-disable-gplv3: drop LMP_DISABLE_GPLV3
1ad6665 
This variable is not used anymore.

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
@quaresmajose
base: rename bbclass lmp-disable-gplv3 to lmp-no-gplv3
d6310ac 
- This naming alling better with the upstream implementation in oe-core
- Also add the no-gplv3.inc upstream config as a new requirment

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
@quaresmajose
base: lmp-image-common: add IMAGE_INCOMPATIBLE_LICENSE/EXCEPTIONS var…
af36637 
…iants

The oe-core INCOMPATIBLE_LICENSE and the INCOMPATIBLE_LICENSE_EXCEPTIONS
can be image specific using overrides but for this to happen we need to know
the image name in advance. The syntax for that is for example the following:

INCOMPATIBLE_LICENSE:pn-core-image-minimal = "GPL-3.0-or-later"
INCOMPATIBLE_LICENSE_EXCEPTIONS:pn-core-image-minimal = "bash:GPL-3.0-or-later"

So for cases where we don't know the name of the image the above solution doesn't work.

To get around this problem we introduce these two variables IMAGE_INCOMPATIBLE_LICENSE
and IMAGE_INCOMPATIBLE_LICENSE_EXCEPTIONS that can be defined globally to mimic
the image override.

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
@quaresmajose
base: lmp-no-gplv3: Populate IMAGE_INCOMPATIBLE_LICENSE
8efa246 
Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
@quaresmajose
base: image-license-checker: drop bbclass
bf0cbb9 
We can drop this bbclass since we can cover most of the existing cases with
the existing upstream variables INCOMPATIBLE_LICENSE and INCOMPATIBLE_LICENSE_EXCEPTIONS
plus our recently added IMAGE_INCOMPATIBLE_LICENSE and IMAGE_INCOMPATIBLE_LICENSE_EXCEPTIONS.

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
quaresmajose added a commit to quaresmajose/ci-scripts that referenced this pull request Oct 31, 2025
@quaresmajose
lmp/bb-config: add support to the lmp-no-gplv3
0bdf876 
With [1] we replace the bitbake bbclass image-license-checker and lmp-disable-gplv3 bbclass
with the lmp-no-gplv3 bbclass which which also includes definitions implemented in oe-core.

The IMAGE_LICENSE_CHECKER_* is not need anymore and the control is made now with the
variable IMAGE_INCOMPATIBLE_LICENSE.

[1] foundriesio/meta-lmp#1618

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
quaresmajose added a commit to quaresmajose/ci-scripts that referenced this pull request Oct 31, 2025
@quaresmajose
lmp/bb-config: add support to the lmp-no-gplv3
889c20c 
With [1] we replace the bitbake bbclass image-license-checker and lmp-disable-gplv3 bbclass
with the lmp-no-gplv3 bbclass which also includes definitions implemented in oe-core.

The IMAGE_LICENSE_CHECKER_* is not need anymore and the control is made now with the
variable IMAGE_INCOMPATIBLE_LICENSE.

[1] foundriesio/meta-lmp#1618

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
@ricardosalveti
Copy link
Copy Markdown
Member

ricardosalveti commented Oct 31, 2025 •
edited
Loading

Can you compare the image manifest from before / after the change? Hopefully it should match.

@quaresmajose
Copy link
Copy Markdown
Member Author

quaresmajose commented Nov 3, 2025

Can you compare the image manifest from before / after the change? Hopefully it should match.

The image manifest is the same as expected.

ricardosalveti pushed a commit to foundriesio/ci-scripts that referenced this pull request Jan 7, 2026
@quaresmajose @ricardosalveti
lmp/bb-config: add support to the lmp-no-gplv3
02f818e 
With [1] we replace the bitbake bbclass image-license-checker and lmp-disable-gplv3 bbclass
with the lmp-no-gplv3 bbclass which also includes definitions implemented in oe-core.

The IMAGE_LICENSE_CHECKER_* is not need anymore and the control is made now with the
variable IMAGE_INCOMPATIBLE_LICENSE.

[1] foundriesio/meta-lmp#1618

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
@quaresmajose quaresmajose merged commit ee3dd69 into foundriesio:main Jan 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angolini angolini angolini approved these changes

@ricardosalveti ricardosalveti ricardosalveti approved these changes

+1 more reviewer

@MrCry0 MrCry0 MrCry0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@quaresmajose quaresmajose

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@quaresmajose @ricardosalveti @MrCry0 @angolini