Skip to content

Run flake8 directly instead of pytest-flake8#182

Merged
dd-jy merged 4 commits into
mainfrom
flake
Jun 16, 2026
Merged

Run flake8 directly instead of pytest-flake8#182
dd-jy merged 4 commits into
mainfrom
flake

Conversation

@dd-jy

@dd-jy dd-jy commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Description

Run flake8 directly instead of pytest-flake8

Summary by CodeRabbit

  • Chores
    • Updated development dependencies and tooling extras for a smoother local setup.
    • Adjusted the release quality-check workflow to run linting independently from the test suite.
  • Quality / CLI
    • Improved the --formats argument handling to explicitly treat provided format values as strings (no change to default behavior).

Signed-off-by: 석지영/책임연구원/SW공학(연)Open Source TP <jiyeong.seok@lge.com>
@dd-jy dd-jy self-assigned this Jun 16, 2026
@dd-jy dd-jy added the chore [PR/Issue] Refactoring, maintenance the code label Jun 16, 2026
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@dd-jy, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 38 minutes and 29 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3527a114-04d5-4767-9ac4-555280f7d6d3

📥 Commits

Reviewing files that changed from the base of the PR and between f8fca4c and 47f4584.

📒 Files selected for processing (4)
  • src/fosslight_scanner/cli.py
  • src/fosslight_scanner/common.py
  • src/fosslight_scanner/fosslight_scanner.py
  • tox.ini
📝 Walkthrough

Walkthrough

pytest-flake8 is removed from pyproject.toml dev extras and importlib-metadata is added in its place. The tox.ini [testenv:release] command switches from pytest -v --flake8 to a standalone flake8 invocation. A CLI argument definition in test fixture sample code is updated to explicitly set type=str.

Changes

Dev tooling and testing infrastructure updates

Layer / File(s) Summary
flake8 standalone migration
pyproject.toml, tox.ini
pytest-flake8 is dropped from dev extras and importlib-metadata is added; the tox release environment command switches from pytest -v --flake8 to a direct flake8 call.
CLI argument type specification
tests/fixtures/scan_project/sample_code.py
The --formats CLI argument definition is updated to explicitly set type=str alongside existing nargs='*' and default=[] parameters.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Run flake8 directly instead of pytest-flake8' accurately summarizes the main change: migrating from the pytest-flake8 plugin to running flake8 as a standalone tool, as evidenced by changes in tox.ini and pyproject.toml dependencies.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch flake

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tox.ini`:
- Around line 35-38: The changedir directive in the release test environment
(set to {toxinidir}/tests at line 35) is causing the bare flake8 command to only
lint the tests directory instead of the entire project codebase. Remove the
changedir line from the release environment configuration so that flake8 runs
from the project root and lints all source files and tests, ensuring that
source-file lint regressions are caught during CI.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e6aff049-e3b4-47ed-bc09-b3e168b34d4b

📥 Commits

Reviewing files that changed from the base of the PR and between 3925941 and af3feb7.

📒 Files selected for processing (2)
  • pyproject.toml
  • tox.ini
💤 Files with no reviewable changes (1)
  • pyproject.toml

Comment thread tox.ini Outdated
dd-jy added 3 commits June 16, 2026 13:22
Signed-off-by: 석지영/책임연구원/SW공학(연)Open Source TP <jiyeong.seok@lge.com>
Signed-off-by: 석지영/책임연구원/SW공학(연)Open Source TP <jiyeong.seok@lge.com>
Signed-off-by: 석지영/책임연구원/SW공학(연)Open Source TP <jiyeong.seok@lge.com>
@dd-jy dd-jy merged commit 0a24cbd into main Jun 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant