Skip to content

Remove 'vulnerability link' column from result report#181

Merged
bjk7119 merged 1 commit into
mainfrom
bin_report
Jun 9, 2026
Merged

Remove 'vulnerability link' column from result report#181
bjk7119 merged 1 commit into
mainfrom
bin_report

Conversation

@bjk7119

@bjk7119 bjk7119 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Updated binary report output format: replaced "Vulnerability Link" column with "Comment" column in the BIN_FL_Binary sheet.
    • Fixed binary report headers to now properly include extended and hidden column headers in generated output files.

@bjk7119 bjk7119 requested a review from dd-jy June 8, 2026 08:55
@bjk7119 bjk7119 self-assigned this Jun 8, 2026
@bjk7119 bjk7119 added the chore [PR/Issue] Refactoring, maintenance the code label Jun 8, 2026
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PR updates binary report header handling by centralizing column definitions. The BIN_EXT_HEADER constant in common.py changes its "Vulnerability Link" column label to "Comment", and fosslight_scanner.py imports and applies these header constants during output file generation instead of passing empty dictionaries.

Changes

Binary Report Header Definition and Application

Layer / File(s) Summary
Binary sheet header definition
src/fosslight_scanner/common.py
The BIN_EXT_HEADER constant for the BIN_FL_Binary sheet is updated to replace the "Vulnerability Link" column header with "Comment".
Header application in output generation
src/fosslight_scanner/fosslight_scanner.py
Imports BIN_EXT_HEADER and BIN_HIDDEN_HEADER from .common and uses these constants in the write_output_file() call instead of empty header dictionaries when generating binary report output.

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title 'Remove "vulnerability link" column from result report' directly matches the main change: replacing 'Vulnerability Link' header with 'Comment' in the binary report output.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bin_report

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bjk7119 bjk7119 changed the title Remove 'vul. link' column Remove 'vulnerability link' column from result report Jun 8, 2026
@bjk7119 bjk7119 merged commit 4b5e9a6 into main Jun 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants