Skip to content

fix(regions): drop redundant stack field from Stack resource#355

Open
Dav-14 wants to merge 1 commit into
mainfrom
fix/regions-stack-redundant-field
Open

fix(regions): drop redundant stack field from Stack resource#355
Dav-14 wants to merge 1 commit into
mainfrom
fix/regions-stack-redundant-field

Conversation

@Dav-14
Copy link
Copy Markdown
Contributor

@Dav-14 Dav-14 commented May 5, 2026

Summary

  • Remove spec.stack from the Stack resource in charts/regions/templates/stack.yaml — the stack identity already lives in metadata.name, and the duplicated key produced an unused field in the rendered manifest.
  • Bump regions to 3.9.3 and the formance umbrella to 1.8.2; regenerate Chart.lock, READMEs, and charts/membership/values.schema.json.

Test plan

  • helm lint charts/regions passes
  • helm template charts/regions renders cleanly (via nix develop -c just helm-template charts/regions)
  • Schemas regenerate idempotently with helm schema -f values.yaml -o values.schema.json
  • CI green

Note: just pre-commit currently fails on main at the helm-schema step because the upstream helm-values-schema-json plugin no longer supports verification and renamed -input-f. That is being fixed in #353; schemas here were regenerated with the corrected invocation.

🤖 Generated with Claude Code

The Stack resource already identifies itself via metadata.name; spec.stack
duplicated that and produced an extra unused key in the rendered manifest.

Bumps regions to 3.9.3 and formance umbrella to 1.8.2.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Dav-14 Dav-14 requested a review from a team as a code owner May 5, 2026 08:31
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8c6c48c5-2f58-4bb7-90bb-d40b8899242b

📥 Commits

Reviewing files that changed from the base of the PR and between 7049e0c and 2371cbb.

⛔ Files ignored due to path filters (5)
  • charts/formance/Chart.lock is excluded by !**/*.lock, !**/*.lock
  • charts/formance/Chart.yaml is excluded by !**/*.yaml
  • charts/membership/values.schema.json is excluded by !**/*.json
  • charts/regions/Chart.yaml is excluded by !**/*.yaml
  • charts/regions/templates/stack.yaml is excluded by !**/*.yaml
📒 Files selected for processing (3)
  • README.md
  • charts/formance/README.md
  • charts/regions/README.md

Walkthrough

Version numbers for two Helm charts are bumped: Formance from 1.8.1 to 1.8.2 and Regions from 3.9.2 to 3.9.3. Updates are reflected consistently across the root README and individual chart README files.

Changes

Helm Chart Version Bumps

Layer / File(s) Summary
Version Updates
README.md, charts/formance/README.md, charts/regions/README.md
Formance chart version incremented to 1.8.2 and Regions chart version incremented to 3.9.3 in all README badges and documentation tables.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

release

Poem

🐰 A hop, a skip, chart versions grow,
From 1.8.1 to 1.8.2 we go!
Regions climb from 3.9.2 with care,
New releases bloom, fresh air!
README's dance, so neat and bright. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: removing the redundant stack field from the Stack resource in the regions chart.
Description check ✅ Passed The description clearly explains the primary change (removing spec.stack), the version bumps, regenerated files, test results, and relevant context about upstream issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/regions-stack-redundant-field

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant