fix(regions): drop redundant stack field from Stack resource#355
Conversation
The Stack resource already identifies itself via metadata.name; spec.stack duplicated that and produced an extra unused key in the rendered manifest. Bumps regions to 3.9.3 and formance umbrella to 1.8.2. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (3)
WalkthroughVersion numbers for two Helm charts are bumped: Formance from 1.8.1 to 1.8.2 and Regions from 3.9.2 to 3.9.3. Updates are reflected consistently across the root README and individual chart README files. ChangesHelm Chart Version Bumps
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
spec.stackfrom the Stack resource incharts/regions/templates/stack.yaml— the stack identity already lives inmetadata.name, and the duplicated key produced an unused field in the rendered manifest.regionsto3.9.3and theformanceumbrella to1.8.2; regenerate Chart.lock, READMEs, andcharts/membership/values.schema.json.Test plan
helm lint charts/regionspasseshelm template charts/regionsrenders cleanly (vianix develop -c just helm-template charts/regions)helm schema -f values.yaml -o values.schema.json🤖 Generated with Claude Code