Skip to content

fix(regions): bump deprecated version threshold to v2.2.0#330

Merged
flemzord merged 2 commits into
mainfrom
fix/regions-deprecated-version-threshold
May 11, 2026
Merged

fix(regions): bump deprecated version threshold to v2.2.0#330
flemzord merged 2 commits into
mainfrom
fix/regions-deprecated-version-threshold

Conversation

@flemzord
Copy link
Copy Markdown
Member

Summary

  • Bump the semver threshold for the formance.com/deprecated annotation from v2.0.0 to v2.2.0 in the Versions CRD template
  • Versions below v2.2.0 are now marked as deprecated
  • Chart version bumped to 3.8.2

Test plan

  • just pc passes (lint, schema generation, template rendering)

@flemzord flemzord requested a review from a team as a code owner March 17, 2026 14:50
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 17, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (5)
  • charts/console-v3/Chart.lock is excluded by !**/*.lock, !**/*.lock
  • charts/formance/Chart.lock is excluded by !**/*.lock, !**/*.lock
  • charts/membership/Chart.lock is excluded by !**/*.lock, !**/*.lock
  • charts/portal/Chart.lock is excluded by !**/*.lock, !**/*.lock
  • charts/regions/templates/versions.yaml is excluded by !**/*.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c97d00c0-2427-4e6f-b274-94541c7714d1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Two README files have their Regions chart version badge updated from 3.8.1 to 3.8.2. The changes are purely version number increments with no modifications to other content or structure.

Changes

Cohort / File(s) Summary
Version Badge Updates
README.md, charts/regions/README.md
Regions chart version badge bumped from 3.8.1 to 3.8.2 in both files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

release

Suggested reviewers

  • gfyrag

Poem

🐰 A little hop, a version's gleam,
From 3.8.1 to 3.8.2, it seems!
In README's rows, the numbers dance,
A release milestone—give it a chance! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions bumping a deprecated version threshold, but the raw summary shows only version number updates in README files with no changes to CRD templates or deprecation logic. Verify that the changes actually include updates to the Versions CRD template's formance.com/deprecated annotation threshold, or update the title to accurately reflect the version bumps in README files.
Description check ❓ Inconclusive The description describes bumping a semver threshold in a Versions CRD template and updating chart version, which aligns with the PR objectives but contradicts the raw summary showing only README version updates. Clarify whether the changeset includes modifications to the Versions CRD template or if the changes are limited to README version bumps, as the description and raw summary appear inconsistent.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/regions-deprecated-version-threshold

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added bug Something isn't working docs release labels Mar 17, 2026
@flemzord flemzord requested a review from a team May 11, 2026 09:28
@flemzord flemzord force-pushed the fix/regions-deprecated-version-threshold branch from 95594cd to 56d45d3 Compare May 11, 2026 09:34
@github-actions github-actions Bot removed the docs label May 11, 2026
@flemzord flemzord enabled auto-merge (squash) May 11, 2026 09:54
@flemzord flemzord merged commit 80ccb87 into main May 11, 2026
5 checks passed
@flemzord flemzord deleted the fix/regions-deprecated-version-threshold branch May 11, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants