chore: expose flows command

[gfyrag]

No description provided.

[coderabbitai]

Walkthrough

The pull request removes the hidden flag from the orchestration command to make it visible in the CLI and updates the ledger-v3-poc submodule to a specific commit.

Changes

Orchestration and Dependencies

Layer / File(s)	Summary
Command Visibility cmd/orchestration/root.go	Removes the fctl.WithHidden() option from the orchestration command constructor, making the command visible in the CLI interface.
Dependency Updates ledger-v3-poc	Updates the submodule reference to commit 4367ce6c9ef962233a4c0a2b308515a3b8374c29.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hidden command steps into the light,
While ledger-v3-poc points true and bright,
Two gentle changes, simple and clean,
Making orchestration visible to be seen! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title 'chore: expose flows command' does not match the actual changes, which involve removing the hidden option from the root orchestration command and updating a submodule reference.	Update the title to accurately reflect the main changes, such as 'chore: remove hidden flag from orchestration root command' or similar.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess whether context and rationale for the changes are documented.	Add a description explaining the purpose of removing the hidden flag and updating the submodule reference to help reviewers understand the intent.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/expose-flows

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ledger-v3-poc`:
- Line 1: The repo contains a staged submodule pointer named "ledger-v3-poc"
without a matching .gitmodules entry which will break git clone
--recurse-submodules and git submodule update; either remove the submodule
commit reference or add a proper .gitmodules entry and initialize the submodule.
To fix, delete the staged submodule entry (undo the commit that adds
ledger-v3-poc) if it's unrelated, or create and commit a correct .gitmodules
section referencing ledger-v3-poc with the correct URL and path, run git
submodule sync && git submodule update --init --recursive to verify, and ensure
no code references ledger-v3-poc remain (search for ledger-v3-poc) before
pushing.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8e6b579d-8dd5-425f-80ac-8dbf8cabed26

📥 Commits

Reviewing files that changed from the base of the PR and between 2c531a2 and 839e9eb.

📒 Files selected for processing (2)

• cmd/orchestration/root.go
• ledger-v3-poc

💤 Files with no reviewable changes (1)

• cmd/orchestration/root.go

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Submodule pointer in PR HEAD =="
git ls-tree HEAD ledger-v3-poc

echo "== Submodule pointer in origin/main =="
git ls-tree origin/main ledger-v3-poc || true

old_sha="$(git ls-tree origin/main ledger-v3-poc 2>/dev/null | awk '{print $3}')"
new_sha="$(git ls-tree HEAD ledger-v3-poc | awk '{print $3}')"

echo "old_sha=${old_sha:-<none>}"
echo "new_sha=${new_sha:-<none>}"

if [[ -n "${old_sha:-}" && -n "${new_sha:-}" && "$old_sha" != "$new_sha" ]]; then
  echo "== Commit range in submodule (old..new) =="
  git -C ledger-v3-poc log --oneline --no-merges "${old_sha}..${new_sha}" || \
    echo "Submodule checkout may be missing locally; run: git submodule update --init --recursive"
fi

Repository: formancehq/fctl

Length of output: 266

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== PR context: Checking recent commits and PR-related info =="
# Look at recent commit messages to understand the PR objective
git log --oneline -10

echo ""
echo "== Checking if ledger-v3-poc dir exists and git module config =="
if [ -f .gitmodules ]; then
  echo "Contents of .gitmodules:"
  cat .gitmodules
fi

echo ""
echo "== Checking what files changed in this PR (HEAD vs origin/main) =="
git diff --name-only origin/main..HEAD | head -20

Repository: formancehq/fctl

Length of output: 331

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Changes to cmd/orchestration/root.go =="
git diff origin/main..HEAD -- cmd/orchestration/root.go

echo ""
echo "== Check .gitmodules status (added, modified, etc) =="
git diff --cached --name-only origin/main..HEAD | grep -i gitmodules || echo "(no .gitmodules in diff)"
git diff origin/main..HEAD -- .gitmodules || echo "(no .gitmodules file in repo or no changes)"

echo ""
echo "== Submodule status =="
git config -f .gitmodules --name-only --get-regexp '^submodule\.' || echo "(no .gitmodules or submodule config)"
git submodule status 2>/dev/null || echo "(submodule command failed or no submodules configured)"

Repository: formancehq/fctl

Length of output: 2352

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Git status of ledger-v3-poc =="
git status -- ledger-v3-poc || echo "(no status)"

echo ""
echo "== Check git ls-files (staged changes) =="
git ls-files --stage -- ledger-v3-poc

echo ""
echo "== Check if ledger-v3-poc exists on disk =="
if [ -d ledger-v3-poc ]; then
  echo "Directory exists. Checking if it's a git repo:"
  if [ -d ledger-v3-poc/.git ]; then
    echo "  Yes, it's a git repo (or submodule)"
    cd ledger-v3-poc && git log --oneline -3 && cd ..
  else
    ls -la ledger-v3-poc | head -10
  fi
else
  echo "Directory does NOT exist on disk"
fi

echo ""
echo "== Check what git status says (untracked, staged, modified) =="
git diff-index --cached HEAD -- ledger-v3-poc || echo "(no staged changes)"

Repository: formancehq/fctl

Length of output: 533

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== Check git history for .gitmodules =="
git log --all --full-history -- .gitmodules | head -5 || echo "(no history found)"

echo ""
echo "== List all untracked/ignored files matching 'modules' or 'submodule' =="
git ls-files --others --ignored --exclude-standard | grep -i 'module\|ledger' || echo "(none found)"

echo ""
echo "== Check if ledger-v3-poc is referenced in any source code =="
rg -l "ledger-v3-poc" --type-list | head -5 || true
rg "ledger-v3-poc" 2>/dev/null | head -10 || echo "(no references found)"

echo ""
echo "== Summary of what's staged =="
git diff-index HEAD

Repository: formancehq/fctl

Length of output: 711

---

Remove the unrelated and incorrectly configured ledger-v3-poc submodule or complete its configuration.

The ledger-v3-poc submodule pointer is staged without a corresponding .gitmodules configuration file, which will break git clone --recurse-submodules and git submodule update commands for anyone pulling this PR. Additionally, this submodule has no references in the codebase and appears unrelated to the PR's stated objective of exposing the flows command. Either remove this commit entirely or add the missing .gitmodules configuration and verify its necessity.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ledger-v3-poc` at line 1, The repo contains a staged submodule pointer named
"ledger-v3-poc" without a matching .gitmodules entry which will break git clone
--recurse-submodules and git submodule update; either remove the submodule
commit reference or add a proper .gitmodules entry and initialize the submodule.
To fix, delete the staged submodule entry (undo the commit that adds
ledger-v3-poc) if it's unrelated, or create and commit a correct .gitmodules
section referencing ledger-v3-poc with the correct URL and path, run git
submodule sync && git submodule update --init --recursive to verify, and ensure
no code references ledger-v3-poc remain (search for ledger-v3-poc) before
pushing.