frameclock: make backend adapters stateless - #47
Merged
waywardmonkeys merged 1 commit intoJul 2, 2026
Merged
Conversation
Remove the retained `AppleFrameClock` and `WebFrameClock` wrappers so backend crates no longer mirror `FrameDriver` lifecycle state. The backend APIs now expose tick-to-`FrameOpportunity` helpers, leaving `request`, `begin`, `submit`, and `discard` ownership with hosts and `frameclock::FrameDriver`. Add the same `frame_opportunity` shape for Apple, Web, and Wayland and update the examples and READMEs to drive `FrameDriver` directly. Apple keeps platform facts as stateless helpers: `DEFAULT_FEEDBACK_MODE` maps the selected display-link source to `FrameSubmission`, and `preferred_frame_rate_range_for_frame` keeps ProMotion call sites compact. This keeps platform crates responsible for display-link facts and presentation hints, while hosts stay responsible for retained frame lifecycle and native presentation resources.
waywardmonkeys
force-pushed
the
frameclock/drop-retained-wrappers
branch
from
July 2, 2026 20:19
8ad79de to
698ff6e
Compare
waywardmonkeys
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the retained
AppleFrameClockandWebFrameClockwrappers so backend crates no longer mirrorFrameDriverlifecycle state. The backend APIs now expose tick-to-FrameOpportunityhelpers, leavingrequest,begin,submit, anddiscardownership with hosts andframeclock::FrameDriver.Add the same
frame_opportunityshape for Apple, Web, and Wayland and update the examples and READMEs to driveFrameDriverdirectly. Apple keeps platform facts as stateless helpers:DEFAULT_FEEDBACK_MODEmaps the selected display-link source toFrameSubmission, andpreferred_frame_rate_range_for_framekeeps ProMotion call sites compact.This keeps platform crates responsible for display-link facts and presentation hints, while hosts stay responsible for retained frame lifecycle and native presentation resources.