fix: Effect refactor of notifications code + other bug fixes from Shane's code review - W-23549971 - #7950
Open
daphne-sfdc wants to merge 18 commits into
Open
Conversation
…ta and Org Browser extensions
…549971-code-review-bugs
…549971-code-review-bugs
…549971-code-review-bugs
* refactor(services): own notification mode service - W-23549971 * fix: metadata commands use new neater notifications wiring method --------- Co-authored-by: Daphne Yang <daphne.yang@salesforce.com>
daphne-sfdc
requested review from
mshanemc
and removed request for
mingxuanzhangsfdx
August 4, 2026 13:45
…549971-code-review-bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses Shane's code review comments in https://salesforce-internal.slack.com/archives/D06U0MJ7QCF/p1784751251951729. No functionality change.
What issues does this PR fix or reference?
@W-23549971@