Skip to content

fix: bump lls version W-19605327 - #6553

Closed
madhur310 wants to merge 9 commits into
developfrom
madhur/bump-lls-v
Closed

fix: bump lls version W-19605327#6553
madhur310 wants to merge 9 commits into
developfrom
madhur/bump-lls-v

Conversation

@madhur310

Copy link
Copy Markdown
Contributor

What does this PR do?

bumps lls version to latest one, does NOT include any changes for tree shaking yet since that PR is in review.
publishing this to get security issue resolved https://github.com/forcedotcom/salesforcedx-vscode/security/dependabot/64

What issues does this PR fix or reference?

@W-19605327@

@madhur310
madhur310 requested a review from a team as a code owner September 17, 2025 21:50
@madhur310

Copy link
Copy Markdown
Contributor Author

The check failures are because of:

✖  salesforcedx-vscode-lightning:compile
      > salesforcedx-vscode-lightning@64.14.0 compile
      > tsc -p ./
      
      src/index.ts(8,10): error TS2724: '"@salesforce/lightning-lsp-common"' has no exported member named 'detectWorkspaceType'. Did you mean 'WorkspaceType'?
      src/index.ts(8,31): error TS2305: Module '"@salesforce/lightning-lsp-common"' has no exported member 'isLWC'.
      npm error Lifecycle script `compile` failed with error:
      npm error code 2
      npm error path /Users/madhur.shrivastava/salesforcedx-vscode/packages/salesforcedx-vscode-lightning
      npm error workspace salesforcedx-vscode-lightning@64.14.0
      npm error location /Users/madhur.shrivastava/salesforcedx-vscode/packages/salesforcedx-vscode-lightning
      npm error command failed
      npm error command sh -c tsc -p ./
      
      

————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————
   ✖  salesforcedx-vscode-lwc:compile
      > salesforcedx-vscode-lwc@64.14.0 compile
      > tsc -p ./
      
      src/index.ts(8,10): error TS2724: '"@salesforce/lightning-lsp-common"' has no exported member named 'detectWorkspaceType'. Did you mean 'WorkspaceType'?
      src/index.ts(8,31): error TS2305: Module '"@salesforce/lightning-lsp-common"' has no exported member 'isLWC'.
      npm error Lifecycle script `compile` failed with error:
      npm error code 2
      npm error path /Users/madhur.shrivastava/salesforcedx-vscode/packages/salesforcedx-vscode-lwc
      npm error workspace salesforcedx-vscode-lwc@64.14.0
      npm error location /Users/madhur.shrivastava/salesforcedx-vscode/packages/salesforcedx-vscode-lwc
      npm error command failed
      npm error command sh -c tsc -p ./

this is expected since the PR isn't merged in yet.

@daphne-sfdc daphne-sfdc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Summary:

Passing Tests:

    ✔ Go to Definition (JavaScript) (19304ms)
    ✔ Go to Definition (HTML) (25080ms)
    ✔ Autocompletion (11890ms)
Found test file: ./packages/salesforcedx-vscode-automation-tests/lib/test/specs/lwcLsp.e2e.js
Test execution validation completed - test files were found and executed
0

@madhur310

Copy link
Copy Markdown
Contributor Author

The latest publish npm package is causing e2e tests failures because it default internal-development flag to true. There is no straight forward workaround for it, without adding more unnecessary code. I am closing this PR out in favor or moving onto my next task of moving code to mono repo which should eliminate all these issues anyways.

@madhur310 madhur310 closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants