This repository was archived by the owner on May 6, 2026. It is now read-only.
fix: prevent publish test-workspaces W-19605327 #624
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,3 +24,4 @@ npm-debug.log | |
| *.tgz | ||
| .npmrc | ||
| package-lock.json | ||
| core.code-workspace | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,28 @@ | ||
| # Dev config folders | ||
| .circleci/ | ||
| .vscode/ | ||
| coverage/ | ||
| jest/ | ||
| scripts/ | ||
| src/ | ||
| test-workspaces/ | ||
| typings/ | ||
| **/__tests__/ | ||
|
|
||
| # Configuration files | ||
| .eslintignore | ||
| .eslintrc.json | ||
| .huskyrc | ||
| .lintstagedrc | ||
| .prettierrc | ||
| copy-static-assets.ts | ||
| jest.config.js | ||
| jest.setup.js | ||
| tsconfig.json | ||
| tslint.json | ||
|
|
||
| # Development files | ||
| core.code-workspace | ||
|
|
||
| # Ignore artifacts | ||
| *.tgz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,6 +38,6 @@ | |
| "extensions.ignoreRecommendations": true, | ||
| "salesforcedx-vscode-lightning.activationMode": "always", | ||
| "salesforcedx-vscode-lightning.showLightningExplorer": true, | ||
|
Contributor
There was a problem hiding this comment. are these sneaking in from writing base-context? lightning-language-server/packages/lightning-lsp-common/src/base-context.ts Lines 261 to 262 in aaadd02
Contributor
There was a problem hiding this comment. maybe we're missing some kind of check to verify that you're working in the salesforce internal repo that all this supports?
Contributor
There was a problem hiding this comment. the big problem with making changes is that we don't test that scenario at all (using ext for internal development) but there's probably users that need it. |
||
| "salesforcedx-vscode-core.internal-development": false | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. We don't normally use
npmignore. The normal approach is to have afilesproperty on the package.json that says what files go in, instead of trying to explicitly ignore files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ex: https://github.com/forcedotcom/sfdx-core/blob/69c0055e7303decdc6d4d79d4ea1944f7e90287a/package.json#L50
I'd rather have "e2e failed because you forgot to put something in
package.json#files" rather than, "you accidentally package unnecessary stuff because you didn't put it in the.npmignorefile"