incorrect flagging ecma-intrinsics: updated whitelist.js#42
incorrect flagging ecma-intrinsics: updated whitelist.js#42neha-naazneen wants to merge 2 commits into
Conversation
|
Thanks for the contribution! Before we can merge this, we need @neha-naazneen to sign the Salesforce Inc. Contributor License Agreement. |
Bartheleway
left a comment
There was a problem hiding this comment.
According to documentation, Aura only supports ES5 syntax + ES6 Promises which means these functions are not recognized in such context.
A lot of purposed modifications were added in ES6 or later, thus not supported in Aura context.
Have you tested all added functions ? Aura code is compiled with Babel if I am correct which means some unrecognized code might fail the compilation.
|
Hi @Bartheleway, Thanks, |
|
Hello @Bartheleway, thank you for your feedback. I have compiled the code with Babel as requested and tested all the added functions to ensure they exhibit the expected behavior. All tests were successful, confirming that the functions work correctly within the Aura context. |
|
Hey @Bartheleway, I wanted to follow up on the pull request I submitted. I understand that maintainers are often busy, I wanted to check in to see if there's anything I can do to help move the review process along. we are using this as a dependency, it would be greatly appreciated if these changes could be reviewed and merged at your earliest convenience. |
|
Hi @neha-naazneen, I'm not a maintainer of this project, just an umble user like you 😉 |
|
What's the ETA here? |

The rule Validate-JavaScript-APIs(ecma-intrinsics) for JavaScript incorrectly flags couple of intrinsic methods, when they do appear to be part of the ecma specification(https://tc39.es/ecma262/). Upon scrutinizing I found that the whitelist.js used in the implementation(ecma-intrinsics.js) isn't updated. I've updated the whitelist.js.