Update src from private repository for v65 release#1659
Merged
xinyaochen-sudo merged 3 commits intoMay 20, 2026
Conversation
- Refactor ClientBase.getClientName() to support External Client App (ECA) configurations - Fix OAuthFlowHandler batch mode crash by guarding Display.getDefault() calls - Add AppUtil.isRunningInBatchMode() utility method - Rename getClientIDForCurrentEnv() to getEffectiveClientIdForCurrentEnv() - Add unit tests for ClientBase and OAuthFlowHandler
|
Thanks for the contribution! It looks like @xinyaochen-sudo is an internal user so signing the CLA is not required. However, we need to confirm this. |
amers185
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enterprise-api/updated-dataloader) to public GitHubClientBase.getClientName()to support External Client App (ECA) configurations — omits UI/Batch suffix when ECA is configuredOAuthFlowHandlerbatch mode crash by guardingDisplay.getDefault()calls withAppUtil.isRunningInBatchMode()checkgetClientIDForCurrentEnv()togetEffectiveClientIdForCurrentEnv()in LoginClient and HttpTransportImplClientBase.getClientName()andOAuthFlowHandlerbatch mode behaviorTest plan
ClientBaseGetClientNameTestandOAuthFlowHandlerTest