CHANGE @W-20084011@ Updated node dependencies - PMD Version Update from 7.17.0 to 7.18.0 #380
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ import eslintTs from "typescript-eslint"; | |
| import lwcEslintPluginLwcPlatform from "@lwc/eslint-plugin-lwc-platform"; | ||
| import salesforceEslintConfigLwc from "@salesforce/eslint-config-lwc"; | ||
| import sldsEslintPlugin from "@salesforce-ux/eslint-plugin-slds"; | ||
| import eslintCss from "@eslint/css"; | ||
|
Contributor
There was a problem hiding this comment. Why shouldn't be needing this. Doesn't the @salesforce-ux/eslint-plugin-slds config bring this in for us?
Contributor
Author
There was a problem hiding this comment. I have explained the issue in this thread : https://github.com/forcedotcom/code-analyzer-core/pull/380/files#r2554625943 |
||
| import {ESLintEngineConfig} from "./config"; | ||
| import globals from "globals"; | ||
|
|
||
|
|
@@ -132,7 +133,15 @@ export class BaseConfigFactory { | |
| return sldsEslintPlugin.configs['flat/recommended-css'].map((cssConfig: Linter.Config) => { | ||
| return { | ||
| ...cssConfig, | ||
| files: this.engineConfig.file_extensions.css.map(ext => `**/*${ext}`), | ||
| // TODO: Remove this workaround once @salesforce-ux/eslint-plugin-slds v1.0.7+ is released. | ||
| // The SLDS plugin's CSS config references `language: "css/css"` but doesn't register the | ||
| // CSS language plugin in their plugins object. We must add it ourselves to avoid the error: | ||
| // "Could not find 'css' in plugin 'css'". See: https://github.com/salesforce-ux/slds-linter/issues/314 | ||
| plugins: { | ||
| ...cssConfig.plugins, | ||
| css: eslintCss | ||
| } | ||
|
Comment on lines
+141
to
+144
Contributor
There was a problem hiding this comment. Why are you adding in the plugin. Shouldn't the cssConfig be bringing in this plugin for us?
Contributor
Author
There was a problem hiding this comment. I have explained the issue in this thread : https://github.com/forcedotcom/code-analyzer-core/pull/380/files#r2554625943 |
||
| }; | ||
| }); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephen-carter-at-sf @jfeingold35 : The
@salesforce-ux/eslint-plugin-sldspackage provides CSS linting rules, but ESLint v9 requires a separate language plugin (@eslint/css) to parse CSS files . Hence I have added Added@eslint/cssdependency in the package.json ""@eslint/css": "^0.14.1"," .Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @salesforce-ux/eslint-plugin-slds package already has a dependency on @eslint/css because they directly depend on it. Unless we directly depend on @eslint/css within our engine package, it shouldn't be in our package.json. We should be relying on pulling in config objects (which pull in plugins) - not plugins directly.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephen-carter-at-sf : I debugged the issue . It's a bug with SLDS plugin .
The SLDS plugin has
@eslint/cssas a dependency and referenceslanguage: "css/css"in their config, but they never actually register the CSS plugin:We need to add
@eslint/cssas a direct dependency and manually register it when consuming their config to fix this issue.I have logged a bug on SLDS team : salesforce-ux/slds-linter#314