CHANGE @W-19688830@ Updated node dependencies - #374
Conversation
| let configs: Linter.Config[] = validateAndGetRawLwcConfigArray(); | ||
|
|
||
| // TODO: Remove the For the following 2 updates when https://github.com/salesforce/eslint-config-lwc/issues/158 is fixed |
There was a problem hiding this comment.
@jfeingold35 is turning this off still necessary? It looks like the original bug was turned off (not sure if this eslint plugin still needs to update or if that og bug being fixed is sufficient)
There was a problem hiding this comment.
The Issue is still open, so I think it might still be necessary.
stephen-carter-at-sf
left a comment
stephen-carter-at-sf
left a comment
There was a problem hiding this comment.
Maybe you can l
| "@salesforce/code-analyzer-engine-api": "0.30.0", | ||
| "@types/node": "^20.0.0", | ||
| "@salesforce/code-analyzer-engine-api": "0.31.0-SNAPSHOT", | ||
| "@types/node": "^24.9.0", |
There was a problem hiding this comment.
I've gone back and forth on this and researched it to death without getting a great answer... should we be updating @types/node if we want to ensure support of node 20?
We probably can I don't know if there are any risks here - which is why I've kept these at 20.0.0 for a while. It also helps us not accidentally rely on a node type that is a later version I believe. Since core modules are imported by clients... we wouldn't want a client being prevented from compiling because it compiles using node 20. But maybe @types/node has versioned types?
| "types": "dist/index.d.ts", | ||
| "dependencies": { | ||
| "@types/node": "^20.0.0" | ||
| "@types/node": "^24.9.0" |
There was a problem hiding this comment.
ditto for all of them.
| "@salesforce/eslint-config-lwc": "3.7.2", | ||
| "@salesforce/eslint-plugin-lightning": "1.0.1", | ||
| "@types/node": "^20.0.0", | ||
| "@types/node": "^24.9.0", |
3 participants
No description provided.