CHANGE: @W-19397345@: Use provided workingFolder instead of creating new temp dirs - #346
Merged
Conversation
| "scripts": { | ||
| "build": "tsc --build tsconfig.build.json --verbose", | ||
| "test": "jest --coverage", | ||
| "test": "tsc --build tsconfig.json --noEmit && jest --coverage", |
Contributor
Author
There was a problem hiding this comment.
Sorry for all the noise in the tests. I had to update a bunch of tests since it turns out that Josh's last change failed to make the tests compile. jest doesn't attempt to do any compile when it executes... so I'm adding in a --noEmit bit before running our tests so we don't miss this anymore.
stephen-carter-at-sf
force-pushed
the
sc/W-19397345
branch
3 times, most recently
from
September 9, 2025 21:42
fc3529f to
f487345
Compare
stephen-carter-at-sf
marked this pull request as ready for review
September 9, 2025 21:43
stephen-carter-at-sf
marked this pull request as draft
September 10, 2025 13:27
stephen-carter-at-sf
force-pushed
the
sc/W-19397345
branch
from
September 10, 2025 14:15
f487345 to
b7b972e
Compare
stephen-carter-at-sf
marked this pull request as ready for review
September 10, 2025 14:15
stephen-carter-at-sf
force-pushed
the
sc/W-19397345
branch
from
September 10, 2025 14:21
b7b972e to
98eaaee
Compare
randi274
reviewed
Sep 10, 2025
| @@ -1,20 +1,6 @@ | |||
| import * as tmp from 'tmp'; | |||
Contributor
There was a problem hiding this comment.
Can tmp be removed as a dependency in this package now? I see we also have the types in the eslint engine and I'm not sure we need those either:
Contributor
Author
There was a problem hiding this comment.
Nice catch. Fixed!
randi274
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.