Skip to content

NEW: @W-18395429@ Add SLDS Config Settings and Rules to ESLint (v9) - #328

Merged
randi274 merged 8 commits into
devfrom
randi/W-18395429-eslint-config-for-slds
Aug 15, 2025
Merged

NEW: @W-18395429@ Add SLDS Config Settings and Rules to ESLint (v9)#328
randi274 merged 8 commits into
devfrom
randi/W-18395429-eslint-config-for-slds

Conversation

@randi274

@randi274 randi274 commented Aug 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR:

  • Adds new SLDS rules for Lightning Web Components HTML and Salesforce CMP files
  • Adds a new setting for the ESLint engine disable_slds_base_config to turn off these new SLDS rules
  • Adds a new file extension for the ESLint engine html (.html, .htm, and .cmp) to be used for rule discovery of particular files
  • Note: settings are available with v9's flat config only

randi274
randi274 commented Aug 14, 2025
View reviewed changes
Comment thread packages/code-analyzer-eslint-engine/test/engine.test.ts
randi274
randi274 commented Aug 14, 2025
View reviewed changes
Comment thread packages/code-analyzer-eslint-engine/src/rule-mappings.ts Outdated
randi274
randi274 commented Aug 14, 2025
View reviewed changes
Comment thread packages/code-analyzer-eslint-engine/src/missing-types-for-dependencies.d.ts
stephen-carter-at-sf
stephen-carter-at-sf reviewed Aug 14, 2025
View reviewed changes
Comment thread packages/code-analyzer-eslint-engine/src/base-config.ts Outdated
@randi274
randi274 force-pushed the randi/W-18395429-eslint-config-for-slds branch from 48288df to 37586ad Compare August 15, 2025 13:46
stephen-carter-at-sf
stephen-carter-at-sf requested changes Aug 15, 2025
View reviewed changes
Comment thread packages/code-analyzer-eslint-engine/src/config.ts Outdated
stephen-carter-at-sf
stephen-carter-at-sf requested changes Aug 15, 2025
View reviewed changes
Comment thread packages/code-analyzer-eslint-engine/src/rule-mappings.ts Outdated
jfeingold35
jfeingold35 reviewed Aug 15, 2025
View reviewed changes
Comment thread ...ages/code-analyzer-eslint-engine/test/test-data/workspaceWithFlatConfigMjs/eslint.config.mjs Outdated
Comment thread packages/code-analyzer-eslint-engine/src/rule-mappings.ts Outdated
@randi274
randi274 force-pushed the randi/W-18395429-eslint-config-for-slds branch from f929a57 to acfd26a Compare August 15, 2025 17:47
@randi274
randi274 merged commit a084f4b into dev Aug 15, 2025
7 checks passed
@stephen-carter-at-sf
stephen-carter-at-sf deleted the randi/W-18395429-eslint-config-for-slds branch August 15, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfeingold35 jfeingold35 jfeingold35 left review comments
@stephen-carter-at-sf stephen-carter-at-sf stephen-carter-at-sf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@randi274 @jfeingold35 @stephen-carter-at-sf