FIX @W-19261289@ SFGE treats LimitReached errors as internal errors - #325
Merged
Conversation
stephen-carter-at-sf
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for Code Analyzer issue 1868, in which triggering a LimitReached exception within Graph Engine tanks the entire code analysis because it is returned as a violation for the non-existent
LimitReachedpseudo-rule.The fix is to change the pseudo-rule name to
InternalExecutionErrorso that the pseudo-violation is handled with the same mechanism that handles timeouts and internal errors.NOTE: Despite my best efforts, I was unable to write code that would trigger a LimitReached error, and was therefore unable to add an automated test. The best I could do was to change line 97 of
PathExpansionRegistry.javafromif (currentSize >= pathExpansionLimit) {toif (currentSize >= 0) {, thereby forcing a LimitReached exception to fire for every single scan, and manually verify that the exception was logged as an error instead of returned as a violation.