@W-22607468: [MSDK Android] Using application/json Content Header For Actionable Notification Action Submission With Empty Request Body Causes Endpoint Errors

[JohnsonEricAtSalesforce]

🎸 Ready For Review 🥁

This simple update changes the content type header for actionable notifications action submission requests to the one the endpoint expects.

[JohnsonEricAtSalesforce]

A subtle hint from the code review tools was to use the empty byte array so future reviews won't see the content type and string as a mismatch.

[bbirman]

Why does it need an empty body at all?

[JohnsonEricAtSalesforce]

I was sure I remembered plus the code review tools were pretty sure as well: Our third-party networking library has a hard rule that POST requests must have a non-null body. There's an unsafe constructor for RestRequest that had tripped this up when I first built the actionable notifications client:

    public RestRequest(RestMethod method, String path, Map<String, String> additionalHttpHeaders) {
        this(method, path, (RequestBody) null, additionalHttpHeaders);
    }

When method is POST a null requestBody triggers this exception.

2026-05-22 00:09:14.517  6622-6667  AndroidNat...inTemplate com.salesforce.androidnativekotlin   E  Failed to invoke notification action
                                                                                                    java.lang.IllegalArgumentException: method POST must have a request body.
                                                                                                    	at okhttp3.Request$Builder.method(Request.kt:341)
                                                                                                    	at com.salesforce.androidsdk.rest.RestClient.buildRequest(RestClient.java:333)
                                                                                                    	at com.salesforce.androidsdk.rest.RestClient.sendSync(RestClient.java:391)
                                                                                                    	at com.salesforce.androidsdk.rest.NotificationsApiClient.submitNotificationAction(NotificationsApiClient.kt:112)
                                                                                                    	at com.salesforce.androidsdk.app.SalesforceSDKManager.invokeServerNotificationAction(SalesforceSDKManager.kt:751)
                                                                                                    	at com.salesforce.androidsdk.app.SalesforceSDKManager.invokeServerNotificationAction$default(SalesforceSDKManager.kt:744)
                                                                                                    	at com.salesforce.androidnativekotlin.MainApplication$InvokeNotificationActionBroadcastIntentReceiver$onReceive$1.invokeSuspend(MainApplication.kt:229)
                                                                                                    	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:34)
                                                                                                    	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
                                                                                                    	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:589)
                                                                                                    	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:832)
                                                                                                    	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:720)
                                                                                                    	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:707)

So it seems we still need the non-null empty request body for this POST request. Good question, 'cuz I'd asked the same when I first tried it 😆

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.01%. Comparing base (b9411ff) to head (8852e9a).
⚠️ Report is 6 commits behind head on dev.

Files with missing lines	Patch %	Lines
...lesforce/androidsdk/rest/NotificationsApiClient.kt	0.00%	1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #2900      +/-   ##
============================================
- Coverage     55.17%   55.01%   -0.16%     
+ Complexity     2509     2504       -5     
============================================
  Files           226      226              
  Lines         17781    17774       -7     
  Branches       2328     2327       -1     
============================================
- Hits           9810     9778      -32     
- Misses         6966     6993      +27     
+ Partials       1005     1003       -2     

Components	Coverage Δ
Analytics	48.71% <ø> (ø)
SalesforceSDK	41.61% <88.88%> (-0.31%)	⬇️
Hybrid	59.30% <ø> (ø)
SmartStore	78.22% <ø> (ø)
MobileSync	82.12% <ø> (ø)
React	51.50% <ø> (ø)

Files with missing lines	Coverage Δ
...rc/com/salesforce/androidsdk/rest/RestRequest.java	93.54% <100.00%> (ø)
...lesforce/androidsdk/rest/NotificationsApiClient.kt	0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.