Fix Token Migration silent failure.#2892
Merged
brandonpage merged 1 commit intoMay 20, 2026
Merged
Conversation
wmathurin
approved these changes
May 19, 2026
Contributor
wmathurin
left a comment
There was a problem hiding this comment.
I think that iOS supports both but I only wrote tests that migrates from using user agent to using web server flow (not the other way around).
Given that user agent is going away and that apps are planning to move to using web server flow before using the new migration APIs, I'm fine with only doing web server flow for refresh token migration.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2892 +/- ##
=========================================
Coverage 55.07% 55.08%
- Complexity 2502 2508 +6
=========================================
Files 226 226
Lines 17781 17774 -7
Branches 2328 2327 -1
=========================================
- Hits 9793 9790 -3
+ Misses 6981 6980 -1
+ Partials 1007 1004 -3
🚀 New features to boost your workflow:
|
brandonpage
added a commit
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration always uses the Web Server regardless of the user's preferred login flow because
LoginViewModel.generateMigrationAuthorizationPathhard-codesuseWebServerAuthentication = trueby design. The OAuth callback therefore always carries an authorizationcoderather than a token fragment so we should exchange it for tokens unconditionally.